Vague GM's feedback

Index > Game Forums > 💡 Gamers' Plane development > ✅ Pull requests > Enhancement/qol2_fixes

Be sure to read and follow the guidelines for our forums.

Adam

Nov 3, 2021 7:28 am
Nov 3, 2021 7:28 am
Vague GM's feedback
vagueGM says:

Heading (H2) size on announcements is very large, especially since they will spend most of their time collapsed. Why `font-size: 2.2em`? 1.8em like the other headers is fine. Maybe 1em when collapsed?

Why the 1rem padding on the notificationMsgs? Inheriting the default is fine. I have not tested with more than one notification (yes, I know about the open games), but can not see why it would be different.

Pin, Lock, and maybe move buttons are massive. Do they need to be that big? Why `font-size: 2em`? 1em is fine. Why force 24px in height and width? None seems fine but a smaller value would work too.
This is single dev style blindness. I stopped noticing things after a while.
vagueGM says:

Code blocks are not monospaced, so text alignment is not possible.
Code blocks are stripping out backslashes, so ascii art (for maps maybe) is not possible, even after color hack to force monospace.
Monospace code was discussed..
There was disagreement about what code blocks were for, but only you thought they should be monospaced. I stuck with the status quo.

vagueGM

Nov 3, 2021 7:48 am
Nov 3, 2021 7:48 am
Vague GM's feedback
Adam says:
This is single dev style blindness.
Blindness would make me make ALL the fonts bigger. :)
Adam says:
Monospace code was discussed..
There was disagreement about what code blocks were for, but only you thought they should be monospaced. I stuck with the status quo.
I remember that and still disagree since we are actively changing that from the default in reset.css. If we had not changed it would be monospaced, as all code blocks are, everywhere else. But I can force them to be mononspaced, so whatever, others may find it the deviation from the default surprising.

They are still messing with the characters though. The extra linebreaks are sorted out (thanks for that) but \\ (backslash) characters are being interpreted by the display code when they should not. The purpose of code blocks is to not interpret those characters (along with the '[' open braces). Needing to double all \\\\s breaks things a bit.
Mark as unread
Index > Game Forums > 💡 Gamers' Plane development > ✅ Pull requests > Enhancement/qol2_fixes

You do not have permission to post in this thread.