bug/nested_bbtags

Some tags allow nesting (quote for example), but most don't, and break if nested.

If would be useful if all tags allowed nesting.

The most pressing is probably the OOC tag. Quoting an OOC and replying to it is probably OOC action so the whole thing is marked as OOC, but the parts from the original post break the flow and have to be manually removed.

In the case of [ quote] and [ spoiler] it does the right thing. In the case of [ ooc] it should probably just ignore all inner OOCs and close at the last, but expecting them to be balanced is reasonable.

There may be some tags that don't make sense to be nested, they can either break (as they do now) if it not possible to make sense of the nesting, or get ignored.

Can you give me a test case for this?

As in 'example code' or as in 'where would it come up'?

Sample code, please.

Do you mean this:

[ooc]Open ooc1[ooc]ooc2[/ooc]Close ooc1[/ooc]

Renders as:Close ooc1[/ooc]

(just making that we're talking about the same thing)

Exactly. That whole thing should be rendered as OOC. From the first open to the last close.

The situation this has been coming up in involves quoting, which copies the old text, but that should not make a difference.

[/ooc]

Moved this back from development.

KoldikSteelskin discovered that putting too much text in a spoiler caused PHP to have an internal error when using a recursive regex.

...and we do sometimes have a lot of text in spoilers.

It's possibly linked to pcre.backtrack_limit, but I believe this would be a server side ini file change. For now, I've pulled this "fix".