tweak/dice_highest_lowest_mods

Hn and Ln dice suffixes for keeping the highest and lowest n dice.

Also integrated into the DnD 5e adv/dis rollers.

Nice with them all displaying and the strikeout.

The strikeout on the 4 is a easy to miss, but the greyout helps with that.

Do we want that strikeout to extend to the comma (,) between the dice?

It looks really good. It would be even better if you could roll sets of dice and have advantage between those or grey out a result between two different dice, but this should already cover most cases.

I have no preference on whether the comma should be greyed and crossed out or not

Er... 4d6l3 seems to be dropping the highest 3 instead of keeping the lowest 3?
I would expect it to mirror the 4d6h3 which keeps 3.

Good catch.

:)

Hard to see such things with 2d20l1, as it works out the same.

Yeah. I confused myself as I started with DH and DL (for Drop High/Drop Low) options - I refactored it to high/low and then zigged when I should have zagged. I must have figured Drop Highest was the same as Lowest somewhere along my journey.

I've updated staging.

I have seen more than one implantation with only drop lowest and keep highest...

It is now working in Staging now. May test some more edge cases later.

---

Can you believe my rolls though?
Almost like they are tying to trick me into believing it is still only totalling one die. :)

In some ways, the most important part of that check-in was adding some comments to the dice roller code so I can follow it in the future. How deep are those arrays?!

As you said: Dice rollers are complex code --and code that takes user input, too. Comments are good, and those ones look like good ones.

Probably a rare-ish case but if you try to keep a double digit number of dice, it seems to only read the last digit

Keep 20 fails to do the right thing as well, and keeps them all, dropping none.

I think that's the same issue as with my Keep 10 above. I assume it reads a 0, which it doesn't accept and so just ignores the command. Or something

Quite right. 25d6h22 keeps two.

Cheers. Nice catch.



I needed to keep the * with the \d.

Updated staging.

Seems to be working now!

Presumably that should be be + rather than *, right? It does not make sense for there to be zero digits after the hlHL.