2 and 3 Column layout, excessive padding

Mar 26, 2022 1:15 am
I am not filing this as a bug, since it might be what people want, but I am finding the padding between blocks in the 2- and 3-column layout to be very large.

Mainly I find the vertical spacing strange, it looks like there should be another complete extra line in there.

Maybe the 12px is too much since it is both top and bottom and adds up to 24px between consecutive blocks, I found between 9px and 6px to be about right.

The horizontal spacing between columns does not look too bad, but also looks fine if reduced as above. There is currently only a single `padding: 12px` css rule, so it does not differentiate between top/bottom/right/left.

As an example: See the large gap between 'Handle:' and 'Stress:' below.
Handle:
Angle:
Hunted?:
Stress:
> Overload
Armor:
Armor Heavy Special
Load:
Light Normal Heavy
Mar 26, 2022 4:52 am
I think you're right. It's pretty lazy having the same for vertical and horizontal, and I think it's using pixels from when the columns were in that fixed-width setup.

padding:.2em .5em;?

For any small changes like this, let me know what you want changing in the .less file (e.g. this one is here) and I'll make the updates in a branch, and deploy to staging. Or do the whole github merge request thing if you have lots of changes.

Can you make a note of changes for people to test them on staging?
Mar 26, 2022 8:15 am
Adam says:
... do the whole github merge request thing if you have lots of change ...
Should the pull request go to your github or the main one?
Adam says:
... Can you make a note of changes for people to test them on staging? ...
Can do.

I will experiment with some different sizes and then we can start getting feedback.
Mar 26, 2022 11:22 am
Probably my github so it'll be easy to merge into a candidate branch for staging.

The CSS has been neglected. There were a lot of changes for the mobile stuff, but it's not polished. You might spot other things, esp considering that there's desktop, dark and mobile.
Mar 26, 2022 12:17 pm
Adam says:
... Probably my github ...
Will do.
Adam says:
... CSS has been neglected ... might spot other things ...
More eye do help.

You do not have permission to post in this thread.