Forum Upgrade!

So, its 2 am, but I finally go the forum upgrade done, before Dreamation. Time to head to bed. The problem: I won't be on much for the next two days, and I was stupid enough to build this upgrade in a way that I can't undo it. And unfortunately, there are bugs I didn't notice in dev popping up on the live site. I've already spent 20 minutes fixing one of them, and found a second. I'm sure there are a lot more.

I'm hoping you guys can help me find the bugs, and I can spend what time I have over the weekend fixing them.

Hi Keleth

Thanks for all your efforts. I am afraid I am seeing a lot of problems with the upgrade, namely:
1. I have a PM but get error when I open it so can't read it
2. Quote doesn't work
3. Page number in black box on thread doesn't show right number
4. Can't edit previously written posts

Many thanks!

For clarity, I should add:
1. Errors when clicking "quote"
2. Errors when clicking "personal message"
3. No option to edit posts (only quote link appears)
4. Page numbering messed up. For example shows 0 of 6 no matter what page you are on

Thanks

Here is message displayed when trying to open an old PM:

---

Fatal error: Call to a member function getAuthor() on a non-object in /var/www/gamersplane/javascript/markItUp/markitup.bbcode-parser.php on line 108
Call Stack
# Time Memory Function Location
1 0.0001 232272 {main}( ) ../dispatch.php:0
2 0.0041 340328 require( '/var/www/gamersplane/pms/view.php' ) ../dispatch.php:69
3 0.0048 352968 BBCode2Html( ) ../view.php:32

---

EDIT: Fast work, Keleth!

1) I'm not getting an error with quote. Can you elaborate on it?
2) Fixed the PM bug.
3) Fixed the edit bug.
4) Gotta look into that; I'm not seeing it either.

Keleth, you are awesome...
1) sorted... sort of
2) sorted
3) sorted
4) On a thread with 6 pages I see 0 of 6 in black box no matter what page I am on and only see selection for pages 1 and 2 and last.

(Hmmm, why didn't quote work?)

New bug... when I click "Reply" or "Advanced" on game thread I get this error (below). However I can reply to this thread, interestingly...

( ! ) Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[42S22]: Column not found: 1054 Unknown column 'p.useID' in 'on clause'' in /var/www/gamersplane/forums/post.php on line 94
( ! ) PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'p.useID' in 'on clause' in /var/www/gamersplane/forums/post.php on line 94
Call Stack
# Time Memory Function Location
1 0.0000 233328 {main}( ) ../dispatch.php:0
2 0.0044 343192 require( '/var/www/gamersplane/forums/post.php' ) ../dispatch.php:69
3 0.0088 585040 query ( ) ../post.php:94

Merlin, if you could clarify what you mean by "Sort of" above, I can fix whatever is sort of broken, heh.

Also, try posting in a game forum again, should be good.

Keleth... Yes, game thread seems ok now.

Regarding quote, the quote worked but per my message above the square bracket quotes appear in my message instead of showing as a quote. I'm trying again...

Aha!! Worked this time. And corrected above too. Lol. Sorted.

I just want to say Keleth, you are fricking awesome.

I really shouldn't launch code at 2am when I have to be somewhere at 9am the next day...

Keleth it looks like the dice deck has gone.

Further to my comment on page numbers you can only step forwards through pages and not backwards, and you don't know what page you are on because only "1, 2 and last" show as options and page number is stuck as zero.

I'm getting an error when trying to "Mark forum as read":


( ! ) Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[42S22]: Column not found: 1054 Unknown column 'lastRead' in 'field list'' in /var/www/gamersplane/forums/process/read.php on line 10
( ! ) PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'lastRead' in 'field list' in /var/www/gamersplane/forums/process/read.php on line 10
Call Stack
# Time Memory Function Location
1 0.0000 232320 {main}( ) ../dispatch.php:0
2 0.0041 340816 require( '/var/www/gamersplane/forums/process/read.php' ) ../dispatch.php:69
3 0.0124 341312 query ( ) ../read.php:10

This is also causing all read threads to be marked as unread.

The rest is working great for me!

I've had trouble with page numbers too. The thread view seems to think that the page is always 0/1 that is selected (on the paginator only) but the page's results are properly paginated. So on a 4 page thread it looks like this no matter what page you're on:

Thanks Rusty! That's exactly what I tried to describe.

What forum do you see that in? I put in a fix, and it looks like its working for me, but that fix was in before you put up your post RustInPieces.

I see the issue in Assassins Heart game.

In the EotE game forum, OOC topic. Except now in the forum view the threads no longer have a list of pages. And the bug persists in the thread view still.

I think I've gotten all the bugs except for dice being wonky on posts. I'm working on that now. Anything else I'm missing?

Not certain if it's a bug, but I can only see game forums for games that I'm participating in. All the others that were public are now invisible to me. I've checked for a setting somewhere but can't find one, so I suspect it's a bug?

Edit: After I posted my reply I was taken to the first page of the thread, not the last page/current post like normal.

I second Rustinpieces above. I cannot follow the games I was following.

Also posts made in subforums (at least in games) do not seem to be appearing on the latest posts section of the main page.

Just noticed another issue: threads in the recent activity feed no longer display their parent forum info.
I inserted the underlined text to make it more obvious.

Can you guys tell me which games you were following that aren't showing up? Public games should still be showing.

This is all I see:

---

Okay, that didn't work:

In game forums, I only see: Games Tavern, and the four games I'm playing: The Golden Sea Chronicles, The Assassin's Heart EotE: A Disruptive Commodity and Primeval: Tales of the Anomalies.

No public games, except the ones I am in, are showing. I clicked on the games I am interested to ensure that they are all still public and have confirmed that they are.

Also ability to roll dice on thread has been lost. Attempting to re-enable it by editing the original post does not work. I rechecked the checkbox for dice in the Numenera Setting and Mechanics thread and it has no effect. Attempting to edit again shows the checkbox unchecked.

Yah, I mentioned earlier dice rolls are still being worked on. I'm gonna be working on that during downtime at the con. I'll have a fix sometime between today and tomorrow.

Ah must have missed that. So many post so short a time. Top of this page lol, I am getting blind in my old age.

Public games should be showing again, and I'm working on dice.

Public games are back, busting bugs from the comfort of your hotel room. Excellent and quick response.

Hotel room? What hotel room? I'm doin this from whatever chair I can find in the lobby :p

Even less comfortable and therefore more impressive.

I think I got rolls working.

Thanks, Keleth. I'm sure this is exactly how you wanted to spend your weekend, haha. But I appreciate your dedication, time and talent in improving the site.

One thing that seems odd is that game posts (of games I'm playing) don't seem to be showing up in my Latest Post feed.

So... the opposite of the bug I just fixed? Bah...

Hm... and you're sure there has been a recent post? Is anyone else getting this bug? I've been through the data returned, and it seems to look fine from my side Qralloq. I guess I'm going to have to dig in deeper.

I'm seeing the same thing. The new posts in my games are not showing up on the front page.

Another thing that I'm noticing is that if I hit the "Mark Forum As Read" link on the bottom of the main forum page, all of the sub groups are marked as unread. So, for example, I hit the "Forums" link at the top of the page, scroll down to the bottom and hit "Mark Forum As Read" and then go into the "The Assassin's Heart" forum, all of those forum are marked as unread.

Oh, on the home page? They shouldn't be, now or before. I wanna add them there, but its actually harder than I hoped it would be. I figured I'll update first, and then get in new features.

As for marked as read, that is intended functionality. Its how marked as read works on most forums, and is the only logical way of programming it. I could decouple it, but I'm not sure it makes sense.

Maybe I'm not communicating what I'm seeing here, but when I hit the "Mark Forum As Read" it marks subforms, which I've already read, as UNREAD. I don't think it used to work that way before the upgrade.

Oh, subforums are coming up as UNREAD. I misread/understood what you said. I'll work on fixing that...

Thanks, Keleth!

The marked read issue should be fixed szemely.

I think the forum/subforum icons are showing all as read. I have threads that are unread in the recent posts feed, but the forum view doesn't reflect that.

Yep - I'm seeing the same thing. Looks like the read/unread logic still needs a little tweaking.

I think I adjusted the read/unread logic to correct. Look better now?

Yup, looks much better now.

I'm still having issues with the read/unread logic. Everything keeps getting marked back as unread.

I've been noticing issues and touching it up over the last hour. I think we're at a solid point now?

One thing I've noticed... dice roller working fine, but if you want to reroll you cannot edit your post for the reroll. That used to work, but now you need a new post to do that.

You should have never been able to reroll, just add more roles onto a post. The entire point of the dice roller was to make it so you can't edit rolls that you've already made, just make new ones.

Keleth... yes that's what I meant. Once dice rolls are posted you used to be able to add more dice rolls as an edit. Now you cannot add more dice rolls, or rerolls. It is common to make rerolls in Numenera. For clarity, any rolls that are rerolled remain in the post, but now you cannot add additional rolls.

Yah, the lack of ability to add more rolls is a problem. I'll look into it.

Fixed adding new rolls to edit.

Things look good, Keleth! Thanks a bunch.

I subscribed to a thread but only get notifications when I post!! Lol. There's irony for you.

That's... weird. Looking into it.

Fixed.