Testing needed: Forum speedups on staging

A little bit ago, I pushed new code to staging that should significantly speed up the GP forums and anything related to them. I'd appreciate it if folks could go on to staging and help test. The changes touch everything involving the forums, and if there are any breaking changes, I don't want it to go to prod and risk the site being down for an extended period.

So if you can spare a few minutes, hop onto the staging site and try doing things you'd normally do here:
- Create a new thread
- Post in a thread
- Edit a post
- Make a game
- Create subforums in a game
- Create/edit groups and their permissions in a game
- Move stuff around
- Add rolls/cards in a game
- All the fancy sheet related stuff we have in game forums
- Join someone else's game and post there, and see if you can find an issue (team work!)
- A lot more I cannot possibly think of on my own

The more through test we can do, the better, to avoid finding bugs once it's on prod. The changes should only affect speed; functionality shouldn't have changed. But for example, we know the home page is really slow, so even speeding that up by 50% is great (slower than I'd want, but step by step). Likewise, from my initial tests, checking latest posts or unread posts is much faster, as is searching forums by text.

So head out to staging and do what you will. If it breaks, it can be recovered easily. Let me know if you find it faster or not, and any bugs you may find.

Tried all items listed and looks fine except . . .

I still have trouble editing groups. [Edit] opens the title of the group but he green check and red X do nothing
How am I to add players to a group?

When trying to move a thread I got an errror

---

Custom sheets look fine
PM seems ok
used secondary profile to post in game w/o issue
Add/Remove player fine, Add/Remove character fine

I'll look into group editing.

@Psybermagi That bug has been around for 8 months and if folks have brought it up, I haven't noticed. It's fixed now.

Yeah. Thanks

Everything I tested seems to work. The 'Latest ...' pages are super fast!
Possibly no one brought it up because the Groups are not useful as they are?

There is no way to add players to groups, so they don't serve a function.

This would be the key bug...

Yup, there's no mechanism from the user side. I'll look to see if there is code that just vanished, because I could swear I wrote it, but if not, looks like this is a feature that will just kinda be ignored for now? I'll make sure it's implemented at some point. Though I don't know how much a need there is with having user level permissions on a forum. But I guess it would make parties that are split up easier to hand permissions to?

I'm pretty sure there *was* a mechanism to add players into group, as I distinctly remember doing that in one of my games in approximately 2020. The groups in this game display as empty now, so somewhere along the way it not only broke, but also reset old settings (or changed their visibility). I remember there were some problems with groups during the last big site update, maybe that was the time.

I would like groups back as I used them to group up players who finished their campaigns in my legacy game and give them permissions to view hidden stuff. :D It was a bit handier than making private notes and adding new players to them each time.

I'll see if the code is inaccessible or deleted at some point.

Well, its way faster. I hope it will work out.

I found some things that broke, but I'm not sure which of these are genuine bugs and which are just the way staging works.

Nothing on staging should behave differently than prod without it being a bug. Thanks for catching these; some are likely directly related to the update, the others not. If I can't get them resolved by tomorrow afternoon (so there's time to test them), we'll push the update to next week, since I'll be out this coming Friday through Sunday night.

Of course, I got curious about why, and instead of sleep (and starting to get into a good sleep pattern for my new job), I fixed the problems now. It was mostly rooted in 1 issue, with some minor offshoots. Test again FS?

Congratulations.

All of the stuff I found above works now, so your sleep was not sacrificed in vain! :D

Edit: I did find another thing - I can't log out of staging. :O It just reloads the page without logging out.

Oh, yah, there is one thing different about staging... it uses your prod login credentials. You may have noticed you didn't need to log into staging either? I noticed recently that the way I have the cookies setup, if you're logged into prod, you're logged into staging. It's something I've meant to fix, but I don't think is of any real priority.

No problems here. I was also able to quit a game that I'd recently quit on production, and I was also able to remove the bookmark tag from said game.

Edit: nevermind the old version of this post, this was me accidentally confusing myself. :'D The sheet does exist, I just forgot what it is.
However, the emails for New Character Added still don't include the game name, so that part of the post is still valid!Edit 2: also, I found a single case where a bookmarked game does not show up on the main page. Every other one I tried it with worked, but for some reason this one just doesn't. It is displayed as bookmarked for me but it's nowhere on the main page. D:

The forums for that game are private! You can't get into private forums, no hard you try.

The emails are fixed.