bug/gmExcludePcs

The 'Advanced Rules Definitions' clause `gmExcludePcs` causes players' PCs to not show for them either.

It should either be renamed to `excludePCs`, and the players' sheets can be manually added using the new `playerSheets` clause, or it should not affect players, yeah?

I am in favor of renaming it, else we currently have no way of excluding certain player sheets.

You're right about the functionality, and I think it's a bug.

It was originally added for GMs who never roll for PCs (and presumably don't want to refer to quickly their PC's sheets either).

I think it should still show the players their sheets.

But is this even wanted? I think we should just remove it.

I'm definitely using the feature. If it was gone, it wouldn't be the end of the world but it helped organize one game a lot. Though now with the NPC tags, that might not be as necessary anymore and a lot of that chaos without the tag is just leftover junk from the olden times



vs

So basically, if you feel like it makes sense to remove that feature, go ahead. But know that it will require me to do five minutes of house cleaning!

I was hoping for more functionality, not less, but don't think it is a big deal.

There could be games that have lots of old characters that are not active anymore, this option could be used to remove all the sheets from below the dice roller, thus eliminating the redundant sheets.

I was hoping the new `playerSheets` feature could allow the GM to add back just the active sheets, but, since it adds them for all players, is not useful in that capacity.

---

It could be useful to have an option to be able to exclude certain old/expired sheets. Maybe just a list of sheets that should not be included.

Ah! That's a good reason to leave it in.

gmSheets lets you add player sheets back in.

But only for the GM, right?
And playerSheets adds them for every player, not just the owner.

Yes.
gmSheets are extra sheets seen by the gm.
playerSheets are extra sheets seen by the players.

GMs also see any sheets they've submitted to the game.
Players see any approved characters they've submitted to the game.

I think the bug is that gmExcludePcs stops the players seeing their own PCs.

Agreed.

It's probably not a bug you've seen. The real question is whether your existing stuff still works.