Need testers for some big changes on staging

Jun 29, 2024 6:28 pm

I've been working at removing one of our databases (we currently have two, MySQL and Mongo, removing the latter), and am now ready for some folks to help me test.

For anyone who's willing, please go to https://staging.gamersplane.com on an incognito window (for some reason, it's not working on a browser you're using GP on) and play with the site as you would regular GP. You'll need to register (which is part of the test). Then go around creating characters, games, joining other's games, posting on the forums, deleting characters, etc. No need to spend hours on it. Maybe 2 characters, join a game, create a game, close the game after you accept and reject some folks. I figure if 20ish people test stuff, we'll get a pretty encompassing test. If you find bugs, you can send them to me via email, PM on Discord, or post here. My hope is bugs will be minimal, and non-breaking for the most part.

For the note, once this is all checked out, I'll be doing a second test where I load live data from production onto staging, and see if everyone sees their old data. If that clears too, we'll set a release time for GP. It'll likely be a bit of a longer one, on the other of 2-3 hours.

FlyingSucculent

Jun 29, 2024 7:03 pm

Need testers for some big changes on staging

Time to go break some stuff! :O With love.

(Psst, Keleth, I messaged you back in March about a problem mods can't help me with. You're probably busy right now with new stuff, but when you have time, can you please help? :'D)

runekyndig

Jun 29, 2024 7:18 pm

Need testers for some big changes on staging

I'm creating bug reports as quickly as I can :)

FlyingSucculent

Jun 29, 2024 7:39 pm

Need testers for some big changes on staging

I don't seem to be able to open a game to applications (it says that it changed and then resets after refreshing the page), make it private (clicking on the "make private" does nothing) or edit game settings (infinite loading upon clicking "save", even if nothing changed). Are these bugs, or is it supposed to be like this and we're only testing joining games?

Also the site informed me "You have pending in (game name was here)!". I think it's supposed to be "pending applications". Also the game does not show I have any pending. :(

Last edited June 29, 2024 7:39 pm

vagueGM

Jun 30, 2024 10:19 am

Need testers for some big changes on staging

• I also see the "You have pending <game name>" on the fontpage [ref].

• I was unable to create the first game I tried (no idea why), but the second, third, and fourth attempt worked.

• Games seem to be marked a Public by default, but I can not change that setting, clicking the link does nothing.

• Retiring a game works as it used to. Restoring a game works.

• The 'Players in Game' list on Game Details appears empty, it does not show the GM. (I have not yet added more players.)

• Clicking Submit under 'Submit a Character' appears to do nothing on the page, but I get an email about the character being added. Refreshing the page indicates that the character was added (they no longer show up to be added).

• Creating Characters appears to work as normal.

• Characters appear to be Added to the Library by default. Removing characters from the library does nothing.

• The user profile does not show any created characters or games under 'Character Stats' and 'GM Stats'.

• I can create a thread in a game, and the first post show up, but there is no place to create more posts, it is almost as though the thread is 'locked'?

• Trying to edit the first post in a game thread appears to work until the Save button is pressed, then I get:
`This page isn’t workingstaging.gamersplane.com is currently unable to handle this request.
HTTP ERROR 500`
from https://staging.gamersplane.com/forums/process/post/

• I can not test posting as characters or using the 'roll tables' since I can not post a second time in a game thread.

vagueGM

Jun 30, 2024 12:14 pm

Need testers for some big changes on staging

Dr_B says:

Question: how can I find a game to join , knowing that it has been created on the staging site?

You are welcome to apply to my game at https://staging.gamersplane.com/games/9/

I will invite you to another so we try both methods. But I don't see you as a user (yet), did create a user on the staging server (https://staging.gamersplane.com/)?

@Keleth, the link in your post links to this thread (with staging tacked on).

bowlofspinach

Jun 30, 2024 12:57 pm

Need testers for some big changes on staging

Is it just me or is staging currently down? I'm getting an error just for trying to access staging.gamersplane.com

vagueGM

Jun 30, 2024 1:10 pm

Need testers for some big changes on staging

It should be back now.

vagueGM

Jun 30, 2024 1:34 pm

Need testers for some big changes on staging

• The game invite email is kinda messed up, it does not contain any information about the game and no links we can follow.

• There does not appear to be any way for the player to accept the invite.

vagueGM

Jun 30, 2024 1:37 pm

Need testers for some big changes on staging

• Games are 'closed for application' clicking 'open to applications' appears to work, but refreshing the page shows it did not change.

Dr_B

Jun 30, 2024 2:20 pm

Need testers for some big changes on staging

my username on staging is dr_B_TWO

vagueGM

Jun 30, 2024 2:26 pm

Need testers for some big changes on staging

Dr_B says:

my username on staging is dr_B_TWO

That is on this site. You need to head over to https://staging.gamersplane.com/ and test the new site functionality there.

Dr_B

Jun 30, 2024 2:47 pm

Need testers for some big changes on staging

hmm I managed to screw it up. Thought I did create the new user in staging.

Anyway, this one definitely is in the staging site:

vagueGM

Jun 30, 2024 2:58 pm

Need testers for some big changes on staging

• Subscribing to threads or forums does not work.

• Messages (/pms/) page does not load.

Windyridge

Jun 30, 2024 3:02 pm

Need testers for some big changes on staging

I can't add myself as a GM to my game and apparently no one has received my invites. The screen shot of the invites is in my forum post on staging.

vagueGM

Jun 30, 2024 3:14 pm

Need testers for some big changes on staging

Windyridge says:

... apparently no one has received my invites ...

I have received emails about the invites I have sent my test user. Do you want to invite vagueGM to a game and see if I receive an invite notification?

vagueGM

Jun 30, 2024 3:29 pm

Need testers for some big changes on staging

I received a game invite notification email from doctorbee.

I don't see any indication on any of the pages that I have been invited to a game (but that was always a bit lacking, right?). I see on the game page that I am Invited. Still can not join, of course.

Dr_B

Jun 30, 2024 3:30 pm

Need testers for some big changes on staging

sent out some other invites too

Last edited June 30, 2024 4:10 pm

Dr_B

Jun 30, 2024 3:38 pm

Need testers for some big changes on staging

Bookmarking Games and Characters is functional (ie the bookmark icon stays on consistently):

[ +- ]

but the bookmarked characters and games do not appear when clicking the top menu bar:

[ +- ]

Keleth

Jul 4, 2024 1:52 am

Need testers for some big changes on staging

A bunch of bug fixes have been made. Please try stuff out again and tell me what's still not working.

Dr_B

Jul 4, 2024 10:34 am

Need testers for some big changes on staging

There is still no visible way to accept an invite to a game (as a player) or to accept a player in a game (as a GM)

as a player:

[ +- ]

as a GM:

[ +- ]

Dr_B

Jul 4, 2024 1:15 pm

Need testers for some big changes on staging

in my test game, I created the first thread. When I list it from the main game Forum page (where you'd see all the threads in that game), it looks correct (I am logged in):

[ +- ] grab 1

but the moment I click on that thread it shows me as logged out:

[ +- ] grab 2

(so I have no option to post in that thread. I can Edit the first post, but Quote doesn't do anything either.

vagueGM

Jul 4, 2024 2:03 pm

Need testers for some big changes on staging

• The GM user is showing up on the Game details page, and their characters are listed as submitted to the game.

• Clicking Approve Character does nothing and the character is not added to the game.

• I can Open games for Application, that options persists when the page is reloaded and shows as set, players can Apply to Game.

• As a player clicking the Apply to Game button does nothing. The Request to Join does not appear on the GMs page.

• Even though a game appears Public, players outside the game can not view the forums. They get taken back /forums/ page.

• The Games Tavern thread SeckTestGame appears blank to me. The other threads in that game work as normal.

• As Dr_B's 'as GM' screenshot shows, the game creator/GM has the option to Leave Game, clicking this does nothing.

vagueGM

Jul 8, 2024 4:40 am

Need testers for some big changes on staging

• All games appear Private in the games list https://staging.gamersplane.com/games/list/.

• All games appear Public on their Game Details ages.

• All games appear to have -1 players in the Games list.

Keleth

Jul 9, 2024 1:07 am

Need testers for some big changes on staging

I wasn't able to replicate all the issues you noted @vagueGM. Can you try again? Everything I could replicate, I fixed.

vagueGM

Jul 9, 2024 2:28 am

Need testers for some big changes on staging

Keleth says:

I wasn't able to replicate all the issues you noted @vagueGM. Can you try again? Everything I could replicate, I fixed.

Have you tried as a 'normal user'? Maybe the Keleth user behaves differently?

Creating a second user is also useful for testing adding to games and being a player vs GM in a game.

Without know which you could not replicate I can't comment, I don't want to overwhelm the thread with screenshots.

• Now the Invited Users lists on my games are empty.

• Clicking the Invite user now does nothing.

• I was able to remove the GM's Submitted Character that was awaiting Approval and add it the way it used to work. Here is a screenshot of what it looked like (midway though testing):

• In a game with a character added I don't see the Post As drop-down list.

• I am able to post more than just the first post in a game thread.

• Editing any game thread still yields a Error 500 when hitting Save.

I was able to toggle a game from Open for Applications, but now am not able to re-open it. Both my games are stuck on Closed. Pressing the button appears to change it to Open, but refreshing the page shows it Closed. This was staying as set before.

• Adding a second Allowed Character Sheet type made it so I could not Submit any Characters. Removing the second Allowed Sheet fixed that.

• My games that accept only Custom Sheets also allow me to ... no wait, my 7th Sea character has just become a Custom Character! That is why I was allowed to add it.

I see changes happening to some of these as I write this message, so I will leave off for a while to let things settle.:)

Chalrytharendir

Jul 9, 2024 5:12 pm

Need testers for some big changes on staging

Tried to add a "Location" to my profile and it doesn't save or show up on my profile

In "vague Test game 2" game detail page, when I clicked on public (read the forum) or the forum button in the bottom bar it takes me to the game forum as expected, but in many of the other games details pages, such as "vague game 3," it took me to the main gp forum page

On the game list page, many of the "Open" tags don't match the game details page, which all say "Closed for applications"

Just had time for some preliminary stuff for now, but I'll try to test out more later

Last edited July 9, 2024 5:14 pm

Chalrytharendir

Jul 9, 2024 7:19 pm

Need testers for some big changes on staging

When I try to edit a post, when I click save, the page goes blank and nothing happens. If I go back to the post, the edit wasn't saved.

Chalrytharendir

Jul 9, 2024 7:26 pm

Need testers for some big changes on staging

BBCode polls don't seem to be working. I can see them, but I can't vote.

Chalrytharendir

Jul 9, 2024 7:30 pm

Need testers for some big changes on staging

Not sure if anyone tested @ mentions yet, but I just mentioned a bunch of people on staging to see if that works. Let us know.

Chalrytharendir

Jul 9, 2024 7:36 pm

Need testers for some big changes on staging

I can't approve the submission of a character.

vagueGM

Jul 9, 2024 7:37 pm

Need testers for some big changes on staging

Chalrytharendir says:

Not sure if anyone tested @ mentions yet, but I just mentioned a bunch of people on staging to see if that works. Let us know.

I got a @ mention in 'General Chat > Testing BBCode'.

Chalrytharendir

Jul 9, 2024 8:07 pm

Need testers for some big changes on staging

Perfect, sounds like it's working

vagueGM

Jul 9, 2024 8:41 pm

Need testers for some big changes on staging

• I am able to join a game after an Invite.

• When I hit Edit on a post in a game where I am a player I get an immediate Error 500 page. This is different to when Editing as a GM where the Error 500 comes when I try to save.

Keleth

Jul 9, 2024 9:53 pm

Need testers for some big changes on staging

I do use 3 different users on local and staging, so it wasn't a character issue. The problem ultimately was I made a DB change locally I forgot to push up when I pushed new code.

That said, the only bug I couldn't replicate was public game forums going to the home page. That said, looking at the data, it seems to be because the game you tried, @chalrytharendir, was created before some bug fixes. So while it says public, the settings are actually private. Once we clear up more bugs, it'll probably be a good idea to create new games/characters to make sure any issues are actually code and not data related.

I'm looking into the bbcode polls. I understand that part least and am trying ti figure out how they work, so I can fix it appropriately.

vagueGM

Jul 9, 2024 9:57 pm

Need testers for some big changes on staging

• As the GM I was unable to Approve a Submitted Character, but after I hit the Reject Character button I went back as the player and Submitted that same character again and it was immediately accepted into the game without GM intervention.

• As the player I Withdrew the Character, which worked. I then submitted it again and it was immediately accepted.

• As the GM I Removed the Character, the player then Submitted it again and it asks for Approval. Rejecting it again, this time without trying to Approve first, it asks for Approval. And now hitting Approving Character works.

vagueGM

Jul 9, 2024 9:57 pm

Need testers for some big changes on staging

Keleth says:

... created before some bug fixes. ...

I will make another new game and see if it is different.

Keleth

Jul 9, 2024 10:02 pm

Need testers for some big changes on staging

And I fixed the bb polls.

Keleth

Jul 9, 2024 10:03 pm

Need testers for some big changes on staging

vagueGM says:

• As the GM I was unable to Approve a Submitted Character, but after I hit the Reject Character button I went back as the player and Submitted that same character again and it was immediately accepted into the game without GM intervention.

• As the player I Withdrew the Character, which worked. I then submitted it again and it was immediately accepted.

• As the GM I Removed the Character, the player then Submitted it again and it asks for Approval. Rejecting it again, this time without trying to Approve first, it asks for Approval. And now hitting Approving Character works.

Some of these may require a force refresh as it sounds like older javascript. I'm testing those same things on staging and it seems to be working ok. But sounds like once you cleared our the character, it started working?

vagueGM

Jul 9, 2024 10:06 pm

Need testers for some big changes on staging

I created a new game vague game 2024-07-09.

Open/Closed status seems to work, change, and display properly.

vagueTest Player could apply and be Accepted.

vagueTest Player was still taken to forum home page before applying. Game says it is Public.

Approving Character works.

I appear to be able to post as a Character.

Thread appears empty, this time even missing the first post:

vagueGM

Jul 9, 2024 10:08 pm

Need testers for some big changes on staging

Keleth says:

... Some of these may require a force refresh as it sounds like older javascript. ...

Been doing that. Many things has started working. Will need to take some time to test all the items.

Keleth says:

... But sounds like once you cleared our the character, it started working?

Looks that way.

vagueGM

Jul 9, 2024 10:57 pm

Need testers for some big changes on staging

• Editing posts in game threads seems to be working. Both as a Player and as a GM.

• Toggling Open for Applications seems to be working now, even for old games.

• Toggling Private/Public seems to be working now, even for old games.

• Others can test if they can see the game thread https://staging.gamersplane.com/forums/thread/33677/ screenshoted above, or if it appears blank to them. [b]@[Keleth/b], what do you see there?

Keleth

Jul 10, 2024 12:55 am

Need testers for some big changes on staging

Fixed all the reported bugs vague!

vagueGM

Jul 10, 2024 4:25 am

Need testers for some big changes on staging

Keleth says:

Fixed all the reported bugs vague!

I guess we will need to find some more. :)

• It is asking me to Approve Characters for the GM.

• All our Player Profiles list no Posts, not Characters, and no Games.

• I am unable to send Private Messages. It works up till the point I press Send. The Send button does nothing.

• The Messages page does not load. I get a hovering, pulsing hexagon, over a greyed out page.

• Clicking on a checkbox in a Character Sheet below a post briefly updates the sheet, but then reloads it and loses the changes.
The minimal sheet below should replicate it:


[table="rolls compact"]
  Stat        |                | roll
  Edge        |   [_edge=1/3]  |  [f=";display:none;"]1d10,1d10,1d6[/f]+[_$=edge]
[/table]

Chalrytharendir

Jul 10, 2024 4:29 pm

Need testers for some big changes on staging

I replicated the checkbox bug.

Mobile layout isn't working on the front page.

Multi polls only let you choose one option.

It's seems like all polls are public regardless of tag, but maybe that's because they are my polls.

vagueGM

Jul 10, 2024 4:38 pm

Need testers for some big changes on staging

Chalrytharendir says:

...

It's seems like all polls are public regardless of tag, but maybe that's because they are my polls.

I have to vote before I can see the results. (I don't use the Polls, so I am not sure if 'Public' is about seeing the Poll at all of just about the results.)

Keleth

Jul 10, 2024 7:09 pm

Need testers for some big changes on staging

Alright, fixed all vague's stuff. Not sure how some of it worked before, but sure.

vagueGM

Jul 10, 2024 7:26 pm

Need testers for some big changes on staging

Keleth says:

Alright, fixed all vague's stuff. Not sure how some of it worked before, but sure.

• I still can't Send PMs. The Send button does nothing.

Keleth

Jul 10, 2024 9:48 pm

Need testers for some big changes on staging

Fixed the mobile layout issue, and multi polls. I'm not quite sure how the public flag is supposed to work, based on the code. If anyone knows, I can help fix up whatever may be wrong. But I didn't change how voting works, just where it saves.

vagueGM

Jul 10, 2024 10:43 pm

Need testers for some big changes on staging

Sending, receiving, and reading PMs is working.

Keleth

Jul 10, 2024 11:23 pm

Need testers for some big changes on staging

So I think we're all caught up with bugs. I'll keep testing, but if no one finds anything by EOD tomorrow, I'll test the data transfer.

Adam

Jul 10, 2024 11:45 pm

Need testers for some big changes on staging

Keleth says:

Fixed the mobile layout issue, and multi polls. I'm not quite sure how the public flag is supposed to work, based on the code. If anyone knows, I can help fix up whatever may be wrong. But I didn't change how voting works, just where it saves.

If isPublic is set in pollVote then also store the username against the vote. This is checked in getPollResults.

Feel free to @ me for that stuff.

Last edited July 10, 2024 11:45 pm

vagueGM

Jul 11, 2024 7:31 am

Need testers for some big changes on staging

• Subscribing to Threads and Forums does not work. Clicking the button does nothing.

Chalrytharendir

Jul 11, 2024 2:20 pm

Need testers for some big changes on staging

Polls are working better now, but they still seem to be public even if the public keyword is not included.

What that means is a non-public poll:

[poll="Your question here..." show]yes
no
maybe[/poll]

Which should look like this (shows a generic GP user avatar instead of the voter's avatar):

Instead looks like a public poll:

[poll="Your question here..." show public]yes
no
maybe[/poll]

Which shows the avatar of voters:

Chalrytharendir

Jul 11, 2024 2:26 pm

Need testers for some big changes on staging

If it's helpful, here's Adam's guide to the BBCode polls for more details of use:
Inline Polls Guide

Chalrytharendir

Jul 11, 2024 2:43 pm

Need testers for some big changes on staging

On a character page that is accepted in a game, there usually a link to Forum (the game forum it is accepted in), and Game Details (the game it is accepted in) in the red bar at the bottom of the page. That's missing on staging.

Should look like this:

Currently looks like this:

In the game forum, the Character link in the bottom red bar usually looks like this:

In staging it looks like this (missing the link to the user):

Chalrytharendir

Jul 11, 2024 3:14 pm

Need testers for some big changes on staging

Linking a recruitment thread to a game breaks the recruitment thread: LINK

Keleth

Jul 12, 2024 1:05 am

Need testers for some big changes on staging

All reported bugs to this point are fixed.

vagueGM

Jul 12, 2024 1:20 am

Need testers for some big changes on staging

• I did not approve Keleth's asedge character. I only see the option to Remove Character. I do not see that Character in the Characters menu below the posts.

• The player Keleth is listed above the GM, but that may just be because Keleth is special. :) None of the other players are listed above the GM.

• vague game 3 is listed as Private. I, the GM, can not get to the game's Forum, it takes me to the https://staging.gamersplane.com/forums/ page.

vagueGM

Jul 12, 2024 1:43 am

Need testers for some big changes on staging

• Subscribe status does not persist across page refreshes. It toggles on but is off again after refreshing.

Keleth

Jul 12, 2024 2:11 am

Need testers for some big changes on staging

vagueGM says:

• I did not approve Keleth's asedge character. I only see the option to Remove Character. I do not see that Character in the Characters menu below the posts.

I manually approved the char in the database to do some testing without bothering you.

vagueGM says:

• The player Keleth is listed above the GM, but that may just be because Keleth is special. :) None of the other players are listed above the GM.

I notice
d that but didn't think about it. It should order by GM; I'll figure out why it's not.

vagueGM says:

• vague game 3 is listed as Private. I, the GM, can not get to the game's Forum, it takes me to the https://staging.gamersplane.com/forums/ page.

I didn't change anything that affects that... I'll look into it.

Keleth

Jul 12, 2024 2:25 am

Need testers for some big changes on staging

vagueGM says:

• vague game 3 is listed as Private. I, the GM, can not get to the game's Forum, it takes me to the https://staging.gamersplane.com/forums/ page.

Seems like a group was never created for this game; it's possible something bugged on creation. Could you try making a new game, make it private, and see if the problem is replicatable?

Chalrytharendir

Jul 12, 2024 2:28 am

Need testers for some big changes on staging

When I bookmarked vague's game (vague game 2024-07-09), it put two copies in the games drop-down menu in the header. One regular and one saying that I'm the gm.

Also, usually when you bookmark games, it only shows the games that you bookmarked, but on staging it also shows my other game that I haven't bookmarked.

Chalrytharendir

Jul 12, 2024 2:46 am

Need testers for some big changes on staging

Also, it usually differentiates between game you're in vs games you're just reading. Game you're in have the six-sided die symbol, whereas games you aren't in have the bookmark symbol.

Like this:

On staging they all have the die symbol.

vagueGM

Jul 12, 2024 3:50 am

Need testers for some big changes on staging

Keleth says:

vagueGM says:

• vague game 3 is listed as Private. I, the GM, can not get to the game's Forum, it takes me to the https://staging.gamersplane.com/forums/ page.

Seems like a group was never created for this game; it's possible something bugged on creation. Could you try making a new game, make it private, and see if the problem is replicatable?

It is just that one game (/games/9/). The game created 12 minutes earlier (/games/7/) and the more recent one —created after the database fix— do not exhibit this behaviour. Presumably it was something funny around the time of that game. Shortly before that I was unable to create a game (the Create button did nothing).

vagueGM

Jul 12, 2024 4:14 am

Need testers for some big changes on staging

• Subscription status now now persists across page refreshes.

• Manage Subscriptions page appears empty. Does not list the Forums or Threads I am subscribed to.

• New posts to Subscribed threads do not generate email notifications.

• Administrative Control Panel is all sorts of broken. It does not display Subforums, Groups tab is inaccessible, Permissions tab is missing, Titles are broken:

Chalrytharendir

Jul 12, 2024 7:52 pm

Need testers for some big changes on staging

I received a Message on staging titled "Testing Messaging" but the To and From fields are missing.

FlyingSucculent

Jul 12, 2024 10:42 pm

Need testers for some big changes on staging

Found a seemingly new bug: if I add a character to the library, it automatically adds *all* my characters to the library. And vice versa!

Edit: it also shows different libraries depending on the state my characters are in.

When my characters are added, I see these in the library: GM Stage, Casual Joe, I am a GM, Lady Trial, Mr Test, SeckTestCharachter, SweetKitty, The Sneaky One, vague Custom.
When not, I see: asedge, Mork Borg Art - Katla, vague custom 1, vagueTest Custom 1, vagueTest1.

Last edited July 12, 2024 10:46 pm

FlyingSucculent

Jul 12, 2024 10:58 pm

Need testers for some big changes on staging

With a posted custom sheet, clicking "Create a character" prompts a name dialogue, but does nothing after entering a name. The button itself disappears afterwards.

Sent private message is missing a "Sent" and the name of the player it is sent to. It looks like this:

Quote:

Title
to on July 13, 2024 1:54 am

I also can't delete a sent message, pressing X does nothing.

I'm looking for a game/My game interests section displays as empty in player profiles. Can't even see it on myself.

Manage Subscription page seems to not be working.

Last edited July 12, 2024 11:06 pm

vagueGM

Jul 12, 2024 11:34 pm

Need testers for some big changes on staging

FlyingSucculent says:

Found a seemingly new bug: if I add a character to the library, it automatically adds *all* my characters to the library. And vice versa!
...

Adding a character to the Library appears to toggle all the Characters. I had one already Added to the Library (apparently from before this bug?) and clicking any of the 'buttons' removes them and adds the other two, clicking any of them again removes the two and adds the first one.

vagueGM

Jul 12, 2024 11:35 pm

Need testers for some big changes on staging

FlyingSucculent says:

... Sent private message is missing a "Sent" and the name of the player it is sent to. It looks like this:

Quote:

Title
to on July 13, 2024 1:54 am

• The notification email is also missing the name of the user who sent the PM.

• The date is scrunched up against the WHEN:.

vagueGM

Jul 12, 2024 11:35 pm

Need testers for some big changes on staging

• The front page seems to contain notifications for threads I have subscribed to. The main site sends emails (which many rely on) and does not list them in the Notifications block.

Keleth

Jul 13, 2024 5:25 pm

Need testers for some big changes on staging

Chalrytharendir says:

Also, usually when you bookmark games, it only shows the games that you bookmarked, but on staging it also shows my other game that I haven't bookmarked.

I'm considering whether to change that behavior, so don't count that as a bug atm.

Keleth

Jul 13, 2024 5:26 pm

Need testers for some big changes on staging

Chalrytharendir says:

I received a Message on staging titled "Testing Messaging" but the To and From fields are missing.

What kind of message? A new game, a subscription, etc.

Chalrytharendir

Jul 13, 2024 6:46 pm

Need testers for some big changes on staging

A "Private Messages" message:

Last edited July 13, 2024 6:49 pm

witchdoctor

Jul 14, 2024 1:12 am

Need testers for some big changes on staging

Hey, while the subject is fresh in my mind, could we put some serious distance between the MESSAGES part of the drop-down and the LOGOUT area? That's WAY too close together for comfort on a phone.

Keleth

Jul 16, 2024 1:09 am

Need testers for some big changes on staging

witchdoctor says:

Hey, while the subject is fresh in my mind, could we put some serious distance between the MESSAGES part of the drop-down and the LOGOUT area? That's WAY too close together for comfort on a phone.

Eeer, I've gotta think over how to do that without it looking weird.

FlyingSucculent

Jul 16, 2024 1:13 am

Need testers for some big changes on staging

Maybe you can just move messages to the top menu, maybe next to Games/Characters? Or above the Settings in the dropdown. It is probably less of a problem for a theme switch to be next to the logout?

Keleth

Jul 16, 2024 1:15 am

Need testers for some big changes on staging

vagueGM says:

• The front page seems to contain notifications for threads I have subscribed to. The main site sends emails (which many rely on) and does not list them in the Notifications block.

So we don't want thread notifications in the top? And I've fixed the email bug.

Keleth

Jul 16, 2024 1:15 am

Need testers for some big changes on staging

FlyingSucculent says:

Maybe you can just move messages to the top menu, maybe next to Games/Characters? Or above the Settings in the dropdown. It is probably less of a problem for a theme switch to be next to the logout?

Good idea.

Keleth

Jul 16, 2024 1:15 am

Need testers for some big changes on staging

All bugs that were reported were addressed.

witchdoctor

Jul 16, 2024 1:52 am

Need testers for some big changes on staging

Keleth says:

FlyingSucculent says:

Maybe you can just move messages to the top menu, maybe next to Games/Characters? Or above the Settings in the dropdown. It is probably less of a problem for a theme switch to be next to the logout?

Good idea.

That's exactly what I'm looking for. A re-sort of the item order would really help. If I'm PM-ing very much I run the risk of logging out inadvertently.

vagueGM

Jul 16, 2024 2:41 am

Need testers for some big changes on staging

Keleth says:

... And I've fixed the email bug. ...

I did not receive notification emails.

Posting to a thread in a game sent me to a Error 550 page, but the post was made. No email notifications sent.

Keleth says:

... So we don't want thread notifications in the top? ...

Mainly I don't want to rely on that.

It does not let me know that there is activity when I am not at the computer and checking the site.
It requires me to check the site manually, in which case I can see the threads with posts already.
Worse, it requires me to go to the homepage, which is slow and puts a lot of strain on the server.
It does not clear these notifications when they have been read. So they mount up and need to be cleared, all at once.

Personally, I have never found this feature useful, and would like a way of tuning it off. Users should have the option of choosing which notification methods they want to use.

Maybe those Notification items can be moved from the overworked frontpage to the User Menu? They they will be available from everywhere. Especially if the User Menu is being worked of for the Logout issue.

Maybe whatever notes the need to place an item in that area can also add a snippet of code to the post in question and clear the Notification when the post (or thread) appears on the user's screen? But that is an improvement for later, and not fixing a bug of staging behaving differently to production.

vagueGM

Jul 16, 2024 2:42 am

Need testers for some big changes on staging

witchdoctor says:

Keleth says:

FlyingSucculent says:

Maybe you can just move messages to the top menu, maybe next to Games/Characters? Or above the Settings in the dropdown. It is probably less of a problem for a theme switch to be next to the logout?

Good idea.

That's exactly what I'm looking for. A re-sort of the item order would really help. If I'm PM-ing very much I run the risk of logging out inadvertently.

Presumably the problem is that people accidentally log out. These solutions assume that is a problem when they go to Messages, but moving Messages out of that Menu just bumps the problem along to people who change the Color Theme often.

Maybe it makes sense to instead move the logout button out of the menu? But would adding a little space between it and whatever is above it not do the trick. That Menu is a short list, so some extra space should do no harm?

vagueGM

Jul 16, 2024 2:44 am

Need testers for some big changes on staging

• Clicking the Game Menu on the topbar now take me straight to the Games page instead of dropping down a list of games.

Chalrytharendir

Jul 16, 2024 3:54 am

Need testers for some big changes on staging

vagueGM says:

... Posting to a thread in a game sent me to a Error 550 page, but the post was made ...

I just had a similar experience posting to the Games Tavern, but I got a blank page instead of a 550, and like yours, I found the post was made once I returned to staging's front page.

Last edited July 16, 2024 3:54 am

Chalrytharendir

Jul 16, 2024 3:58 am

Need testers for some big changes on staging

In games, the notes/mentions button doesn't populate with the players names. There are spots, but the names are missing.

This should list Chal and FlyingSucculent in the top 2 spots:

Chalrytharendir

Jul 16, 2024 3:59 am

Need testers for some big changes on staging

vagueGM says:

• Clicking the Game Menu on the topbar now take me straight to the Games page instead of dropping down a list of games.

Same for me.

Chalrytharendir

Jul 16, 2024 4:03 am

Need testers for some big changes on staging

When I tried to reply to this message, I clicked "Send" and nothing happens:

Chalrytharendir

Jul 16, 2024 4:11 am

Need testers for some big changes on staging

Chalrytharendir says:

In the game forum, the Character link in the bottom red bar usually looks like this:

In staging it looks like this (missing the link to the user):

This is still needs fixing.

Chalrytharendir

Jul 16, 2024 5:03 am

Need testers for some big changes on staging

I can't remember if this was reported already, but if so, it's still not working.

If you click the "Create Character" button in a charsheet spoiler, you get a pop-up to fill in the name of the character, but then nothing happens except the "Create Character" button vanishes. When I go to my characters, no character was created.

bowlofspinach

Jul 16, 2024 5:12 am

Need testers for some big changes on staging

vagueGM says:

witchdoctor says:

Keleth says:

FlyingSucculent says:

Maybe you can just move messages to the top menu, maybe next to Games/Characters? Or above the Settings in the dropdown. It is probably less of a problem for a theme switch to be next to the logout?

Good idea.

That's exactly what I'm looking for. A re-sort of the item order would really help. If I'm PM-ing very much I run the risk of logging out inadvertently.

Presumably the problem is that people accidentally log out. These solutions assume that is a problem when they go to Messages, but moving Messages out of that Menu just bumps the problem along to people who change the Color Theme often.

Maybe it makes sense to instead move the logout button out of the menu? But would adding a little space between it and whatever is above it not do the trick. That Menu is a short list, so some extra space should do no harm?

Wouldn't an "Are you sure you want to log out?" pop-up be a fairly easy solution to this problem?

vagueGM

Jul 16, 2024 5:14 am

Need testers for some big changes on staging

bowlofspinach says:

... Wouldn't an "Are you sure you want to log out?" pop-up be a fairly easy solution to this problem?

Definitely a good stopgap measure, and should probably be done anyway. But that popup might get irritating if one kept accidentally hitting it. A some space would still be nice.

Chalrytharendir

Jul 16, 2024 5:34 am

Need testers for some big changes on staging

When editing a game in the Game Details page, the JSON data in the "Advanced Rules Definitions" spoiler usually saves the whitespaces making it easier to read:

On staging, whitespace is not saved making it more difficult to read/edit:

Chalrytharendir

Jul 16, 2024 7:30 pm

Need testers for some big changes on staging

I noticed that the User is missing from the message details in the Inbox for PMs.

Usually it would be:

from doctorbee on July 12, 2024 1:40 am

But it looks like this:

Keleth

Jul 16, 2024 7:48 pm

Need testers for some big changes on staging

Chalrytharendir says:

I can't remember if this was reported already, but if so, it's still not working.

If you click the "Create Character" button in a charsheet spoiler, you get a pop-up to fill in the name of the character, but then nothing happens except the "Create Character" button vanishes. When I go to my characters, no character was created.

Can you link me to this page? I'm not aware of this feature or how to make it work, so can't test it myself.

Keleth

Jul 16, 2024 7:55 pm

Need testers for some big changes on staging

vagueGM says:

I did not receive notification emails.

Posting to a thread in a game sent me to a Error 550 page, but the post was made. No email notifications sent.

I made a typo in the code... should be good now.

Chalrytharendir

Jul 16, 2024 8:09 pm

Need testers for some big changes on staging

This is the page I screenshot on staging: HERE

This is the post in Adam's BBCode guide about how it works (last section of the post): HERE

Here's the post where I shared the sheet on the current site: HERE

There's also lots of examples of its use in the custom character sheet repository: HERE (go to the last page, the tag's use became common more recently than when the thread was first started). Some of these are more simple, which might be better to use if you're troubleshooting. I used this complicated one because I thought it would test many aspects of custom sheets in one shot. The sheet itself is working great, just the ability to create a character from the post is what isn't working.

Actually, I'll go ahead and create a charsheet tag with a simple custom character sheet in staging below the Mork Borg one, so you have something to troubleshoot with.

It should look and behave like this:

[ +- ] Simple Test Character

Last edited July 16, 2024 8:33 pm

FlyingSucculent

Jul 16, 2024 10:19 pm

Need testers for some big changes on staging

Looks like private games are not working. Chalrytharendir was able to see a thread in my allegedly private game.
Chal's screenshot, game in question. Admittedly the game was made before the recent bug fix, so might be a lingering bug.

Decks are not working properly. I have a game with a standard deck added, but site interface constantly claims that it "has 1 cards left" and if I try to draw from it, it won't work unless I only draw a single card.
Edit: scratch this, the problem is with adding a deck. I add a standard deck, it says that it's added with 54 cards, then after refreshing it becomes 1 card. However, if I try to shuffle it, it claims that it has 54 cards.

If I put a character in the library and then delete the sheet, the link remains in the library. (See sheet called Mr. Deleter in staging library.)

GM can't see secret rolls made by players.

Last edited July 16, 2024 10:50 pm

Keleth

Jul 23, 2024 10:36 pm

Need testers for some big changes on staging

Fixed
- bbcode characters
- deck count display
- removing chars from library when deleted
- gms permissions on threads

@FlyingSucculent - Can you try creating a new game and thread to see if folks can still see private games?

Any other bugs I missed in the last week of not working on this?

Chalrytharendir

Jul 24, 2024 5:26 am

Need testers for some big changes on staging

The JSON data is still removing white space when stored.

Chalrytharendir says:

When editing a game in the Game Details page, the JSON data in the "Advanced Rules Definitions" spoiler usually saves the whitespaces making it easier to read:

On staging, whitespace is not saved making it more difficult to read/edit:

The Characters menu doesn't stack multiple characters under the same name, it repeats the User for each character.
Staging:

Main Site:

Chalrytharendir

Jul 24, 2024 5:37 am

Need testers for some big changes on staging

Fliptokens arent' working (Test on Staging).

They are described in the BBCode guide with an example HERE (aka Star Wars Destiny Tokens)

Chalrytharendir

Jul 24, 2024 5:55 am

Need testers for some big changes on staging

The FAQ Page on staging hangs: HERE
Looks like this:

Chalrytharendir

Jul 24, 2024 5:55 am

Need testers for some big changes on staging

Same with the About GP page

Chalrytharendir

Jul 24, 2024 6:13 am

Need testers for some big changes on staging

I was going to say the FORUM RULES link is missing, but discovered it is missing on many of the main site pages as well. Might be good to have it in the footer of all pages like it is in the footer of the ABOUT GP page.

And the LINKS link is missing on staging, but it seems like a pretty broken page even on the main site.

Last edited July 24, 2024 6:27 am

Chalrytharendir

Jul 24, 2024 6:17 am

Need testers for some big changes on staging

If anyone else is looking for things to test, these are things I haven't had time to test yet:
-ACP
-Non-basic dice rolls
-Non-custom character sheets
-private tag
-snippet
-snippets
-d20 roll tables
-dice pool roll tables
-email notifications
-subscriptions

(I think vagueGM tested subscriptions and emails, but not sure)

Otherwise, I think I've poked around with most other things (probably forgetting about a few things). I'm finding fewer and fewer bugs as I test, so I think we are getting close.

vagueGM

Jul 24, 2024 7:07 am

Need testers for some big changes on staging

Chalrytharendir says:

If anyone else is looking for things to test, these are things I haven't had time to test yet: ...

ACP
- Basic functionality seems to work. I have not tested every option.
Non-basic dice rolls
? I don't know what Feng Shui dice are supposed to do, so I don' know if they are correct. They roll something that looks the same as on the main site, take a look [ref].
d20 roll tables
- I guessed about how they work. They seem to work, [table="rolls d20 dnd5e"] yields correct-looking Advantage and Disadvantage in the dice roller.
dice pool roll tables
- tested both pool and pool-add
email notifications
- working
subscriptions

- working

vagueGM

Jul 24, 2024 7:08 am

Need testers for some big changes on staging

Links to characters in the Game Details page are missing the character type (at least for custom).
So they link to:
https://staging.gamersplane.com/characters//4/sheet/
instead of:
https://staging.gamersplane.com/characters/custom/4/sheet

FlyingSucculent

Jul 25, 2024 12:50 am

Need testers for some big changes on staging

Keleth says:

@FlyingSucculent - Can you try creating a new game and thread to see if folks can still see private games?

Made a new game, and I at least can't see its thread among public games posts. Here is the thread if anyone can confirm!

Chalrytharendir

Jul 25, 2024 1:40 am

Need testers for some big changes on staging

Looks good, I got the "403: Don't peek behind the GM screen" page

Last edited July 25, 2024 1:43 am

FlyingSucculent

Jul 25, 2024 1:37 pm

Need testers for some big changes on staging

Nice, thanks for checking! :D

Keleth

Aug 21, 2024 12:57 am

Need testers for some big changes on staging

Sorry for the massive delay in this project. I got around to fixing everything mentioned above (I think). Please let me know!

Chalrytharendir

Aug 24, 2024 5:41 pm

Need testers for some big changes on staging

Chalrytharendir says:

Fliptokens arent' working (Test on Staging).

They are described in the BBCode guide with an example HERE (aka Star Wars Destiny Tokens)

I was able to flip one of the tokens once, but after that I couldn't flip anymore. Usually I can flip all of them as many times as I want:

Fliptokens:

History

Chalrytharendir August 24, 2024 5:41 pm

FlyingSucculent August 24, 2024 5:44 pm

Avraham August 25, 2024 1:05 am

Furmyr August 25, 2024 11:39 am

Keleth August 26, 2024 11:12 pm

Naatkinson August 27, 2024 2:06 am

microtheMacroBear August 27, 2024 7:08 pm

FlyingSucculent

Aug 24, 2024 5:47 pm

Need testers for some big changes on staging

I can't flip fliptokens more than once on staging either. D:

Chalrytharendir

Aug 24, 2024 5:48 pm

Need testers for some big changes on staging

Chalrytharendir says:

And the LINKS link is missing on staging, but it seems like a pretty broken page even on the main site.

This is still missing and when I got there manually (LINKS), it's blank. Not sure if that's intentional or not.

Chalrytharendir

Aug 24, 2024 6:06 pm

Need testers for some big changes on staging

EDIT: This is working now

---
Original message

@FlyingSucculent RE: comment on staging about snippets:

You can't see any of the snippets dropdowns?

I'm actually not sure what the behavior of a handout is for snippets, that might be the way it works on the main site. We should check. Do you have a handout sheet you can test on the main site?

Also, can you see the Post Handout dropdown?

Last edited August 24, 2024 6:44 pm

Chalrytharendir

Aug 24, 2024 6:13 pm

Need testers for some big changes on staging

@FlyingSucculent @vagueGM

I haven't used the private tag before. Check this post out (HERE). This is what it looks like to me:

Can you confirm the appropriate text is private.

FlyingSucculent

Aug 24, 2024 6:20 pm

Need testers for some big changes on staging

I replied on staging, but I can't see anything on the Handout sheet when I choose it. No snippets, no contents. D:
I never used handouts on the main site either, so I'm not sure about how they work.

Also, private tag seems to work correctly to me!

Last edited August 24, 2024 6:21 pm

Chalrytharendir

Aug 24, 2024 6:28 pm

Need testers for some big changes on staging

FlyingSucculent says:

I replied on staging, but I can't see anything on the Handout sheet when I choose it. No snippets, no contents. D:
I never used handouts on the main site either, so I'm not sure about how they work.

I forgot to make the handout public. Try again.

vagueGM

Aug 24, 2024 6:35 pm

Need testers for some big changes on staging

Chalrytharendir says:

...

Can you confirm the appropriate text is private.

I can only see the Private note to myself:

Chalrytharendir

Aug 24, 2024 6:35 pm

Need testers for some big changes on staging

I think the only thing left to test is "Non-custom character sheets."

I haven't used a non-custom sheet in ages, so I'm not the best person to test them.

Also, since there's no way to copy/paste or import non-custom sheets, they might be better to test once a copy of the full database is added in the next phase of testing.

Chalrytharendir

Aug 24, 2024 6:36 pm

Need testers for some big changes on staging

FlyingSucculent says:

... private tag seems to work correctly to me!

vagueGM says:

I can only see the Private note to myself ...

Awesome, thanks!

Last edited August 24, 2024 6:40 pm

Chalrytharendir

Aug 24, 2024 6:44 pm

Need testers for some big changes on staging

Update: Handouts and Snippets are working as expected. Thanks @FlyingSucculent for helping me troubleshoot that.

FlyingSucculent

Aug 24, 2024 6:44 pm

Need testers for some big changes on staging

Player-side character list seems to be bugged. Here is how it looks from Chalrytharendir's and my perspectives in the same game:

[ +- ] Screenshots

It works fine for me in a different game I'm the GM in.

Chalrytharendir

Aug 24, 2024 6:49 pm

Need testers for some big changes on staging

@Keleth So in summary, other than the fliptokens and player-side character lists, I think staging is working really well! Once those two things are debugged, I think we are probably ready for the next phase (migrating a copy of the entire database to staging for testing?) 🤞

Keleth

Aug 26, 2024 11:15 pm

Need testers for some big changes on staging

@Chalrytharendir For the player side list, can you be more clear on what's wrong? A user should only be able to see their own characters if they're not a GM, right? I'm looking into flip tokens, as that works locally, so surprised it's not working on staging.

Keleth

Aug 26, 2024 11:16 pm

Need testers for some big changes on staging

Oh, I forgot to remove something in the database, thus why you could only flip once. Should be good now.

Keleth

Aug 26, 2024 11:16 pm

Need testers for some big changes on staging

I'm gonna work on the full data load tonight, as the player list should be easy enough to fix.

Chalrytharendir

Aug 27, 2024 5:09 am

Need testers for some big changes on staging

On the main site, players can see the links to all characters in a game using that menu. It's often useful for players to see each other's sheets, and if not, players can keep their sheets private.

FlyingSucculent

Aug 27, 2024 7:28 am

Need testers for some big changes on staging

Yeah, and on the main site I would be seeing my own player name on the list, which I don't on staging. So it's a combination of not seeing all player names and other players' characters sheets.

Keleth

Aug 27, 2024 5:24 pm

Need testers for some big changes on staging

Ok, I'll make that change to the character list.

Also, all data is now transferred and converted on staging. If folks don't mind, take a look, see if you think it's slower/the same/faster than prod, and do some feature tests to make sure everything is good. Do some comparisons to data on staging and prod to see if it lines up, specially if you used an emoji or image or something, and if anyone is using languages that use characters that English doesn't (typically).

vagueGM

Aug 27, 2024 5:30 pm

Need testers for some big changes on staging

staging feels significantly faster loading the slow homepage.

top shows mysql only using 32% CPU for the duration of about 7 seconds, as opposed to >180% CPU for >30 seconds on prod. This is surprising.

vagueGM

Aug 27, 2024 5:49 pm

Need testers for some big changes on staging

• A few random players in my games are missing portraits. This might be an irrelevant symptom of how the data was transferred, but met us know if you want us to report each occurrence of such. The data seems to be out of date, so I don't know if those players did not have portraits at that time.

• Character posts are showing the player's portrait.

• The 'Advanced rules definitions' in Game Details were messed up, they were displaying in one long line with \n instead of line breaks. The rules also were not working. Replacing the rules with correct ones from prod fixed both these issues.

• The Gamers' Plane development game has messed up emojis in the game, on the Games menu at the top it shows the lightbulb emoji 'correctly'. Compare with prod.

• Game 'background images' are not showing up. Compare the above two for that as well.

Keleth

Aug 27, 2024 5:57 pm

Need testers for some big changes on staging

vagueGM says:

• A few random players in my games are missing portraits. This might be an irrelevant symptom of how the data was transferred, but met us know if you want us to report each occurrence of such. The data seems to be out of date, so I don't know if those players did not have portraits at that time.

• Character posts are showing the player's portrait.

Yah, don't worry about the avatars.

vagueGM says:

• The 'Advanced rules definitions' in Game Details were messed up, they were displaying in one long line with \n instead of line breaks. The rules also were not working. Replacing the rules with correct ones from prod fixed both these issues.

• The Gamers' Plane development game has messed up emojis in the game, on the Games menu at the top it shows the lightbulb emoji 'correctly'. Compare with prod.

Will look into those.

vagueGM says:

• Game 'background images' are not showing up. Compare the above two for that as well.

Can you give me an example? I can see if it's a code issue or a copy issue.

vagueGM

Aug 27, 2024 6:06 pm

Need testers for some big changes on staging

Keleth says:

...

vagueGM says:

• Game 'background images' are not showing up. Compare the above two for that as well.

Can you give me an example? I can see if it's a code issue or a copy issue.

• 'Gamers' Plane development' game: on prod has a background image, on staging has no background image.

Keleth

Aug 27, 2024 6:18 pm

Need testers for some big changes on staging

vagueGM says:

Keleth says:

...

vagueGM says:

• Game 'background images' are not showing up. Compare the above two for that as well.

Can you give me an example? I can see if it's a code issue or a copy issue.

• 'Gamers' Plane development' game: on prod has a background image, on staging has no background image.

Fixed

Keleth

Aug 27, 2024 6:20 pm

Need testers for some big changes on staging

As for the emojis, I think I have to figure out a different way to do a data load. I'll wait to see if folks find other bugs, and if I don't see anything soon, I'll probably try a data load again.

Keleth

Aug 28, 2024 2:58 am

Need testers for some big changes on staging

So looks like something in how MySQL backed up the data messed up the emojis. I'm not really sure what to do. I'll have to google.

FlyingSucculent

Aug 28, 2024 3:29 am

Need testers for some big changes on staging

It looks like some other symbols are also messed up. In one of my games these occurred:

Quote:

Our captain makes a hard leftâ€" (originally: left—)
Pinkyâ€™s (originally: Pinky’s)

Edit: Also, I have a character named Remíe (with an accented í), and while the name is corrupted in text of posts, the name on the sheet isn't. (It's a 13th Age sheet, if it matters.)

Last edited August 28, 2024 3:45 am

FlyingSucculent

Aug 28, 2024 3:35 am

Need testers for some big changes on staging

Some weirdness with bookmarked characters. I have two on the main site, but on staging I have both of them plus another one. Not a big deal probably, but still weird. (And I haven't changed the bookmarks in a while, so not an old data issue. Probably. Or it might be and I'm misremembering...)

And game bookmarks are fully gone. D:

Speed feels slightly better though!

Last edited August 28, 2024 3:47 am

vagueGM

Aug 28, 2024 10:10 am

Need testers for some big changes on staging

Keleth says:

So looks like something in how MySQL backed up the data messed up the emojis. I'm not really sure what to do. I'll have to google.

FlyingSucculent says:

It looks like some other symbols are also messed up. In one of my games these occurred:

Quote:

Our captain makes a hard leftâ€" (originally: left—)
Pinkyâ€™s (originally: Pinky’s)

Edit: Also, I have a character named Remíe (with an accented í), and while the name is corrupted in text of posts, the name on the sheet isn't. (It's a 13th Age sheet, if it matters.)

So unicode related? Hopefully it is as easy as getting everyone to talk UTF8.

vagueGM

Aug 28, 2024 10:12 am

Need testers for some big changes on staging

FlyingSucculent says:

Some weirdness with bookmarked characters. ... haven't changed the bookmarks in a while, so not an old data issue. ... And game bookmarks are fully gone ...

Both my Games and Characters Bookmarks are not the same on staging as on prod. I also have not changed them in a while. Both menus have entries in them, and are things I had bookmarked at one time.

vagueGM

Aug 28, 2024 12:09 pm

Need testers for some big changes on staging

• On staging, my Subscriptions list is empty.

Keleth

Aug 28, 2024 8:06 pm

Need testers for some big changes on staging

vagueGM says:

So unicode related? Hopefully it is as easy as getting everyone to talk UTF8.

Yah, unicode issues and I don't know what. The current server has all its tables set to UTF8, which is what existed at that point. The new server is using utf8mb4, which supports emojis. So how is our current server supporting emojis? I checked, and we don't do anything special when storing or printing. Yet it works, when every resource I can find online says it shouldn't. And all the initial answers I've gotten say it shouldn't work. In short, I'm stuck. I even got my Stack Overflow question marked duplicate to a related but not the same question.

If anyone has experience with unicode and PHP/MySQL, please reach out, because I don't know what to do.

FlyingSucculent

Aug 28, 2024 8:31 pm

Need testers for some big changes on staging

Sounds like witchcraft to me. D: I wish I could help.
Out of curiosity, since sheets aren't affected by this issue, are they stored by some other method?

Chalrytharendir

Aug 28, 2024 8:43 pm

Need testers for some big changes on staging

@Adam might know.

Adam, sorry if I'm misremembering, but I think some of the features you added involved emojis. Do you remember if they are being stored in a special way, or need to be dealt with in a special way?

vagueGM

Aug 28, 2024 8:44 pm

Need testers for some big changes on staging

Keleth says:

... The current server has all its tables set to UTF8, which is what existed at that point. The new server is using utf8mb4 ...

FlyingSucculent says:

... Pinkyâ€™s (originally: Pinky’s) ...

So presumably prod is using utf8mb3? utf8mb3 stores its values in three bytes, and we are getting three characters ' â€™ ' instead of the ' ’ ' which is 0x2019.

Either the export from the old database or, more likely, the import into the new database is treating these three byte characters as three single byte CP-1252 code page characters, which is what we are seeing displayed on staging.

Keleth says:

... which supports emojis. So how is our current server supporting emojis? ...

Presumably it only supports three byte long emojis? Or is it storing those emojis as three bytes and rendering them 'combined'?

FlyingSucculent says:

... since sheets aren't affected by this issue, are they stored by some other method?

That seem worth looking into. If they are stored differently then it may not help, but if they are exporting or importing differently then it could be an answer?

Are those from the mongodb? If so that indicates the old mysql is the source of the issue?

How did you import the data?

Maybe try adding --default-character-set=utf8 to the mysql import command? Else we might have to look into convincing the old server to export it in way we can use?

Keleth

Aug 28, 2024 8:47 pm

Need testers for some big changes on staging

vagueGM says:

FlyingSucculent says:

... since sheets aren't affected by this issue, are they stored by some other method?

That seem worth looking into. If they are stored differently then it may not help, but if they are exporting or importing differently then it could be an answer?

Are those from the mongodb? If so that indicates the old mysql is the source of the issue?

How did you import the data?

Maybe try adding --default-character-set=utf8 to the mysql import command? Else we might have to look into convincing the old server to export it in way we can use?

Yah, everything copied from mongo is fine, because mongo doesn't really bother with encoding issues; you feed it stuff, it saves it. The issue is strictly the MySQL data being copied over.

I took the latest database backup (a sql file), changed all the tables to be utf8mb4, and then ran them as sql queries. The backup is already using a default character set to export. I'm not sure what other "right way" to export may be. Is it an issue on the import side? I don't know.

vagueGM

Aug 28, 2024 8:50 pm

Need testers for some big changes on staging

The import may be thinking those malformed three byte utf8 characters are three characters. Try telling it you really mean it to treat everything as utf8 with --default-character-set=utf8 .

Keleth

Aug 28, 2024 9:19 pm

Need testers for some big changes on staging

vagueGM says:

The import may be thinking those malformed three byte utf8 characters are three characters. Try telling it you really mean it to treat everything as utf8 with --default-character-set=utf8 .

Already doing that on export and import.

vagueGM

Aug 28, 2024 9:24 pm

Need testers for some big changes on staging

Keleth says:

... Already doing that on export and import.

OK, so if that is not working, maybe

mysqldump --skip-set-charset --default-character-set=utf8mb3

to be explicit on the export?

Or experiment with

mysqldump --skip-set-charset --default-character-set=latin1

so the old server does not try to do anything with the three bytes and leaves them 'as is'?

And then with

mysql --default-character-set=utf8mb4

or

mysql --default-character-set=utf8mb3

to be explicit on the import even if using latin1 on the export?

I don't know if these import options affect how the data is stored, or just how it is treated while being imported, you should be able to ask the database about it afterwards if you imported utf8mb3 with success?

Keleth

Aug 28, 2024 10:09 pm

Need testers for some big changes on staging

So I tried --default-char-set=uft8 on export and --default-char-set=utf8mb3 on import. No luck. I'll try the other two options.

Chalrytharendir

Aug 28, 2024 11:30 pm

Need testers for some big changes on staging

Seems like something is set to ASCII on staging.

In UTF-8, "right single quotation mark" aka ’ is encoded as 3 bytes:
0xe2
0x80
0x99

In ASCII, those three bytes encode:
â
€
™
respectively.

So seems like the data is saved properly in the database, but it's being interpreted as ASCII on staging.

Chalrytharendir

Aug 29, 2024 12:20 am

Need testers for some big changes on staging

I guess the other possibility is that it is being switched during the data migration. Can you read the raw data? If it migrated properly, but it's being interpreted wrong, then the raw data for the incorrect â€™ would be the 3 bytes above. If the data migrated incorrectly then the raw data would be:
0xc3
0xa2
0xe2
0x82
0xac
0xe2
0x84
0xa2

That might help narrow down where the issue is.

Last edited August 29, 2024 12:33 am

FlyingSucculent

Aug 29, 2024 12:29 am

Need testers for some big changes on staging

Unrelated to the Unicode issue, but I just noticed that some of originally private games are listed as public on staging. They aren't actually public, you can't read the forums and the posts don't appear among the recent public posts, but it is a little weird. (It includes games which never have been public )

PS: probably expected at this point, but my test string of Cyrillic did become this:
Ð¢ÐµÑÑ‚, ÑŽ, Ñ‰, Ñ†, Ñ‹, Ñ„. (Originally: Тест, ю, щ, ц, ы, ф.)

Adam

Aug 29, 2024 7:53 am

Need testers for some big changes on staging

Chalrytharendir says:

@Adam might know.

Adam, sorry if I'm misremembering, but I think some of the features you added involved emojis. Do you remember if they are being stored in a special way, or need to be dealt with in a special way?

I seem to remember that the db supported emoji and it was the code that needed changing.

Looking at these release notes: Release notes: 18th September 2021

...and the changes that were merged at around that time...

It seems a rogue utf8_decode was in there and I removed it.

I'd check the code for instances of utf8_decode and see if they're needed.

vagueGM

Aug 29, 2024 11:15 am

Need testers for some big changes on staging

FlyingSucculent says:

... my test string of Cyrillic did become this:
Ð¢ÐµÑÑ‚, ÑŽ, Ñ‰, Ñ†, Ñ‹, Ñ„. (Originally: Тест, ю, щ, ц, ы, ф.)

Did you enter that as new text on staging, after the import, or was that that already in the database?

I meant to try entering new unicode to see if it worked, which would say it was something with the export/import, but have not been able to access staging for a while.

If newly entered emojis or unicode still don't work then we are barking up the wrong tree with the database migration and it is probably something in the code that was there to deal with the old/wrong utf8 implementation in mysql5, and that code is now breaking things where it should stay out of the way. Thanks Adam [ref].

Keleth

Aug 29, 2024 12:55 pm

Need testers for some big changes on staging

FlyingSucculent says:

PS: probably expected at this point, but my test string of Cyrillic did become this:
Ð¢ÐµÑÑ‚, ÑŽ, Ñ‰, Ñ†, Ñ‹, Ñ„. (Originally: Тест, ю, щ, ц, ы, ф.)

I guess this is sort of a clue? Though I don't understand why. The mongo data (like character sheets) is being imported from JSON files via PHP and work. So why are values being input through PHP also not storing correctly? Or rendering correctly?

Unfortunately, I haven't been able to figure out how to view the raw data from a SQL query or in DBeaver.

vagueGM

Aug 29, 2024 1:05 pm

Need testers for some big changes on staging

Keleth says:

... Unfortunately, I haven't been able to figure out how to view the raw data from a SQL query or in DBeaver.

Can you check what the command line mysql tool shows? If it is outputting correct characters then we know it is php messing with things, if it is outputting the strangeness we see then we will need to work out how to replace those character sequences with the correct unicode codepoints.

I haven't looked at the sql, do you know what query would output the data for this page? Or from one of the thread names from that page?

Keleth

Aug 29, 2024 1:06 pm

Need testers for some big changes on staging

vagueGM says:

I meant to try entering new unicode to see if it worked, which would say it was something with the export/import, but have not been able to access staging for a while.

If newly entered emojis or unicode still don't work then we are barking up the wrong tree with the database migration and it is probably something in the code that was there to deal with the old/wrong utf8 implementation in mysql5, and that code is now breaking things where it should stay out of the way. Thanks Adam [ref].

I'm gonna stop various backup/restore methods. I'm not seeing anything different across the board, which is telling me it may not be the MySQL itself.

The PHP docs say it should handle UTF-8 by default, but I'm going to try implementing it directly. As for the code, I started by looking there, and the functions that exist to save data/display data don't do anything that should interfere with emojis. The PHP version is the same on both envs.

vagueGM

Aug 29, 2024 1:07 pm

Need testers for some big changes on staging

Keleth says:

... The PHP version is the same on both envs.

Which is a bit old. If you have to mess with php it might be worth seeing if you can get the site working with version 8 while you are at it?

Keleth

Aug 29, 2024 1:15 pm

Need testers for some big changes on staging

vagueGM says:

Keleth says:

... The PHP version is the same on both envs.

Which is a bit old. If you have to mess with php it might be worth seeing if you can get the site working with version 8 while you are at it?

I tried. Some of the packages we use changed in ways that would require a lot of recoding. If that's the solution, I'll do it, but it'll take time.

vagueGM

Aug 29, 2024 1:16 pm

Need testers for some big changes on staging

Pity to divert V2 for that if we can avoid it.

Keleth

Aug 29, 2024 1:20 pm

Need testers for some big changes on staging

vagueGM says:

Pity to divert V2 for that if we can avoid it.

That was my thought exactly.

vagueGM

Aug 29, 2024 1:24 pm

Need testers for some big changes on staging

Adding new unicode works see this post, so it is not the php.

Once we can see exactly what bits the database is storing for those old ones we could look at scripting a query that goes through and replaces those with the correct points.

This does sound like a problem that others must have come across, maybe there is an existing solution somewhere on google or the mysql forums. What I saw yesterday indicated they knew about issues with mysql 5's utf8 implementation.

Chalrytharendir

Aug 29, 2024 1:31 pm

Need testers for some big changes on staging

Are these two text fields coming from the same piece of data? Because one is rendered properly (Games Dropdown menu) and the other is not (Forum title):

Suggests the underlying data is correct, but it is not being rendered properly in places.

Keleth

Aug 29, 2024 1:40 pm

Need testers for some big changes on staging

Chalrytharendir says:

Are these two text fields coming from the same piece of data? Because one is rendered properly (Games Dropdown menu) and the other is not (Forum title):

Suggests the underlying data is correct, but it is not being rendered properly in places.

That's incredibly useful because yes, there's only one source of data now.

Keleth

Aug 29, 2024 1:43 pm

Need testers for some big changes on staging

Ok, it's likely a PHP issue then. The header displays data via AngularJS. The body displays data is straight from PHP.

FlyingSucculent

Aug 29, 2024 1:51 pm

Need testers for some big changes on staging

vagueGM says:

Did you enter that as new text on staging, after the import, or was that that already in the database?

It was on main and got corrupted by import/export. (I added it after the first import in case there would be another one after Keleth mentioned testing other alphabets.) New posts in Cyrillic on staging do look as they should.

If there is anything that would be useful to test, let me know! :D

Last edited August 29, 2024 1:52 pm

vagueGM

Aug 29, 2024 1:53 pm

Need testers for some big changes on staging

Keleth says:

Ok, it's likely a PHP issue then. ...

That seems correct.

Running the query:
select * from forums where forumID = 8582;
yields
forumID title description forumType parentID heritage order gameID threadCount
8582 🤷‍♂️ Suggestions Add suggestions for improvement here. f 8003 0002-8003-8582 1 3181 29

Which shows the emoji (in the terminal). So it seems the data is correct.

Chalrytharendir

Aug 29, 2024 1:59 pm

Need testers for some big changes on staging

The function that Adam pointed to (Thanks Adam!) is in a php file and converts utf-8 to single byte format (description). That sounds a lot like the culprit we are looking for. Did it get put back in during the refactor?

Keleth

Aug 29, 2024 2:07 pm

Need testers for some big changes on staging

Chalrytharendir says:

The function that Adam pointed to (Thanks Adam!) is in a php file and converts utf-8 to single byte format (description). That sounds a lot like the culprit we are looking for. Did it get put back in during the refactor?

That function isn't in the production code, nor is it in the staging one, so unfortunately it's not the issue.

vagueGM

Aug 29, 2024 8:42 pm

Need testers for some big changes on staging

The data is being corrupted when we put it in through PHP as well. Looking at the data from the new post 1705621, which displays correctly on the staging site, the command line mysql query:

select messageFullText from posts where postID = 1705622;
shows
new unicode test ?, ?, ?, ?, ? ????? ? ? ?? ? ? ? ? ? ? ?

So it is being translated twice and stored wrong, probably to deal with the old database storing it wrong in the first place.

Keleth

Aug 29, 2024 8:49 pm

Need testers for some big changes on staging

vagueGM says:

The data is being corrupted when we put it in through PHP as well. Looking at the data from the new post 1705621, which displays correctly on the staging site, the command line mysql query:

select messageFullText from posts where postID = 1705622;
shows
new unicode test ?, ?, ?, ?, ? ????? ? ? ?? ? ? ? ? ? ? ?

So it is being translated twice and stored wrong, probably to deal with the old database storing it wrong in the first place.

Wait, so new stuff works, both in saving and printing. So that means it's not a PHP issue? Then wtf is the problem. I have no idea what to look at anymore. I'm looking at the code that saves a post to the database, and it doesn't do any modification to the post. Not even tag stripping, which is a big deal. The print part doesn't do any modification for forums.

vagueGM

Aug 29, 2024 9:04 pm

Need testers for some big changes on staging

The old data in the database has correct utf8 strings, but displays wrong.

Anything newly entered has corrupted utf8 strings in the database but displays correctly, so something broke the uft8 before it got to the database, and is fixing it again on its way out of the database, this 'fix' is corrupting the correct utf8 in the database on the way out so it does not display correctly.

Chalrytharendir

Aug 29, 2024 9:24 pm

Need testers for some big changes on staging

vagueGM says:

The data is being corrupted when we put it in through PHP as well. Looking at the data from the new post 1705621, which displays correctly on the staging site, the command line mysql query:

select messageFullText from posts where postID = 1705622;
shows
new unicode test ?, ?, ?, ?, ? ????? ? ? ?? ? ? ? ? ? ? ?

So it is being translated twice and stored wrong, probably to deal with the old database storing it wrong in the first place.

What happens if you do this on the main site? If it's stored like this on the main site, then maybe it's being "fixed" during the migration.

vagueGM

Aug 29, 2024 9:25 pm

Need testers for some big changes on staging

main site new unicode test — ю, щ, ц, ы, ф 💡🤷‍♂️ 💬 🪲 🛠️ 👀 ⏳ ✅ 📅 📓 ❌ 📦

vagueGM

Aug 29, 2024 9:37 pm

Need testers for some big changes on staging

Mysql command line on main site for the the above post yields:

messageFullText
main site new unicode test — ю, щ, ц, ы, ф 💡🤷‍♂️ 💬 🪲 🛠️ 👀 ⏳ ✅ 📅 📓 ❌ 📦

So the main site is storing the data in a way that mysql 5 on the main site understands.

Data imported into the staging database comes out correctly, as per the above post. Only data entered via the website comes out wrong.

Keleth

Aug 29, 2024 11:55 pm

Need testers for some big changes on staging

New information: MySQL 8.4 doesn't like MySQL 5.5's utf8mb4 data?

I took the code on prod and put it on staging, put up the same data, and it all worked like prod. That was expected and all good. I then updated the tables from utf8 to utf8mb4 (the new table structure we want). It continued to work, emojis and all. Then I did a backup of that data and updated to 8.4. When I imported the utf8mb4 data from 5.5, emoji's showed up broken again.

So... I don't know.I'm looking at the code, and it doesn't seem to be doing anything weird. I'm writing up some test code to do as raw a data test as I can.

Avraham

Aug 30, 2024 12:02 am

Need testers for some big changes on staging

I know absolutely nothing about database structures, but does this shed any light whatsoever? https://dba.stackexchange.com/questions/8239/how-to-easily-convert-utf8-tables-to-utf8mb4-in-mysql-5-5

Avraham

Aug 30, 2024 12:03 am

Need testers for some big changes on staging

I know absolutely nothing about database structures, but does this shed any light whatsoever? https://dba.stackexchange.com/questions/8239/how-to-easily-convert-utf8-tables-to-utf8mb4-in-mysql-5-5

Last edited August 30, 2024 12:04 am

Keleth

Aug 30, 2024 12:06 am

Need testers for some big changes on staging

So I just did as raw a test as possible. I created a script that created a database connection, queried for forum 8003, and got back 'ðŸ’¡ Gamers' Plane development'. That means it's not a retrieval issue.

Keleth

Aug 30, 2024 12:13 am

Need testers for some big changes on staging

So here's a great confusing example: https://gamersplane.com/oneRunScripts/check_data.php. That's the raw data from the database just printed out. It does not print out an emoji, as you can see. Why not?

Keleth

Aug 30, 2024 12:14 am

Need testers for some big changes on staging

Avraham says:

I know absolutely nothing about database structures, but does this shed any light whatsoever? https://dba.stackexchange.com/questions/8239/how-to-easily-convert-utf8-tables-to-utf8mb4-in-mysql-5-5

I appreciate the link, and actually found it earlier today. It both added info and confusion.

FlyingSucculent

Aug 30, 2024 12:49 am

Need testers for some big changes on staging

Might it be possible to update incrementally, instead of 5.5 to 8.4 directly? Maybe the jump is what's causing the issue?

I also found this article which contains a detailed instruction on updating utf8 to utf8mb4: link. Perhaps it can be of use? It has pretty detailed steps.

Avraham

Aug 30, 2024 12:50 am

Need testers for some big changes on staging

Keleth says:

Avraham says:

I know absolutely nothing about database structures, but does this shed any light whatsoever? https://dba.stackexchange.com/questions/8239/how-to-easily-convert-utf8-tables-to-utf8mb4-in-mysql-5-5

I appreciate the link, and actually found it earlier today. It both added info and confusion.

Sorry. My thought was that if it is an issue with "regular" utf8 in 5.5 being brought into 8.4, the perhaps converting everything in place in 5.5 and then bringing it in to 8.4 may circumvent whatever is corrupting the translation. But as I said, I know almost nothing about databases per se. I just have some experience with general problem solving. Thanks.

Keleth

Aug 30, 2024 12:57 am

Need testers for some big changes on staging

Avraham says:

Sorry. My thought was that if it is an issue with "regular" utf8 in 5.5 being brought into 8.4, the perhaps converting everything in place in 5.5 and then bringing it in to 8.4 may circumvent whatever is corrupting the translation. But as I said, I know almost nothing about databases per se. I just have some experience with general problem solving. Thanks.

A thought I shared earlier today too, leading me to that article. I actually did try that, and updating utf8 to utf8mb4 in 5.5 worked. Moving past 5.5 did not.

Keleth

Aug 30, 2024 1:00 am

Need testers for some big changes on staging

FlyingSucculent says:

Might it be possible to update incrementally, instead of 5.5 to 8.4 directly? Maybe the jump is what's causing the issue?

Maybe? But utf8mb4 should be the same regardless of version.

FlyingSucculent says:

I also found this article which contains a detailed instruction on updating utf8 to utf8mb4: link. Perhaps it can be of use? It has pretty detailed steps.

I actually found that and that led to me doing my earlier test of utf8 on 5.5 to utf8mb4 on 5.5. As you link see from the link above, I think it actually has something to do with getting PHP to show emojis. I think the fact that it's working now may be conincidental/accidental.

FlyingSucculent

Aug 30, 2024 1:10 am

Need testers for some big changes on staging

I've been attempting to look for various update instructions, and it looks like 5.7 is something of a barrier. One article actually claimed that you can't update 5.6 (and below, presumably) to 8.0 directly (which is questionable :'D). Maybe you can try go 5.5 to 5.7 to 8.4, since it's just one extra step? Maybe it tries to convert something along the way because 5.7 used different defaults.

Last edited August 30, 2024 1:11 am

Keleth

Aug 30, 2024 2:11 am

Need testers for some big changes on staging

5.7 is currently running on staging, and you can see it isn't working :/ I'll try something different tomorrow in regards to 5.7 (putting 5.5 utf8 on staging, upgrading to 5.7, then going utf8mb4). But 5.5 utf8 -> 5.5 utf8mb4 -> 5.7 apparently broke stuff.

I'm wondering if there's something different in how PDO communicated with 5.5 vs 5.7+? Honestly, I'm running out of ideas, and no one online seems to have answers besides "This is clearly a UTF-8 issue you're not handling properly" and "Have you tried (insert all the things I've mentioned here I've tried)".

FlyingSucculent

Aug 30, 2024 2:21 am

Need testers for some big changes on staging

At least we know that it breaks at this point, it's already new information!

And yeah, there isn't a lot on this topic online. :( I'm mostly running into your own posts and old Reddit/MySQL threads with not a lot of actual answers. I saw a Reddit instruction about updating from 5.1 to 8.0 incrementally, but it had no mentions of specific stuff regarding Unicode, unfortunately.

(By the way, I feel your pain in getting responses like "You asked wrong", it's really unhelpful even when done with good intentions.)

FlyingSucculent

Aug 30, 2024 2:46 am

Need testers for some big changes on staging

Also, an interesting piece of information I found:

Quote:

MySQL 8.0 changed the utf8mb4 default collation from utf8mb4_general_ci to utf8mb4_0900_ai_ci
<...>
This has a very significant impact - if the utf8 update if performed on a MySQL 5.7 server, without specifying the collation, and then the server is upgraded to v8.0, the collation of all the data structures will not match the default.
<...>
It’s crucial to be aware of this, because most of the online information about the utf8 conversion has been written when MySQL 8.0 was not released yet, so it holds the outdated assumption that the default utf8mb4 collation is utf8mb4_general_ci.
- Source

utf8mb4general_ci is indeed used in a lot of aforementioned sources. That might be part of the problem too if you're using it instead of utf8mb4_0900_ai_ci? It is about 5.7 to 8.0, but still.

vagueGM

Aug 30, 2024 10:21 am

Need testers for some big changes on staging

Keleth says:

So I just did as raw a test as possible. I created a script that created a database connection, queried for forum 8003, and got back 'ðŸ’¡ Gamers' Plane development'. That means it's not a retrieval issue.

Keleth says:

So here's a great confusing example: https://gamersplane.com/oneRunScripts/check_data.php. That's the raw data from the database just printed out. It does not print out an emoji, as you can see. Why not?

Interesting. Running the same query on the command line shows that php may be breaking things? Command line mysql prints the correct emoji.

Keleth

Aug 30, 2024 12:00 pm

Need testers for some big changes on staging

vagueGM says:

Keleth says:

So I just did as raw a test as possible. I created a script that created a database connection, queried for forum 8003, and got back 'ðŸ’¡ Gamers' Plane development'. That means it's not a retrieval issue.

Keleth says:

So here's a great confusing example: https://gamersplane.com/oneRunScripts/check_data.php. That's the raw data from the database just printed out. It does not print out an emoji, as you can see. Why not?

Interesting. Running the same query on the command line shows that php may be breaking things? Command line mysql prints the correct emoji.

But as far as I can tell, prod is just taking the data and dumping it out in the same way, so why does it work? Why does prod work but a test on prod doesn't?

vagueGM

Aug 30, 2024 12:10 pm

Need testers for some big changes on staging

Keleth says:

... But as far as I can tell, prod is just taking the data and dumping it out in the same way, so why does it work? Why does prod work but a test on prod doesn't?

Given that mysql appears to be returning the correct data on both prod and staging (I get the same output shown in the screenshot above from both), and the php script turns it into garbage on both, it looks to be php related, especially since you noted that where angular was involved it displayed correctly [ref].

If possible, can you spin up a container with newer php and see what your oneRunScripts/check_data.php does with that? Even if new php does not run the site, it will tell us if old php is doing this.

It may be a php setting in the container, and a fresh container with php8 (and no special config) would reveal some of that and tell us where to look next.

Keleth

Aug 30, 2024 1:42 pm

Need testers for some big changes on staging

Yah, I'll try that. So for example, I got MySQL 5.7 working with the existing data. I then updated to MySQL 8.0, but that failed. So there's definitely SOMETHING up between 5.7 and 8 and PHP.

Keleth

Aug 30, 2024 8:23 pm

Need testers for some big changes on staging

Ok, someone gave me a suggestion, and I've added it to the forum title of forums. Can someone check if titles are showing up ok, but posts aren't? If it's working as I hope (and my initial tests seem to suggest), then we know the problem and now have to figure out how to make a final solve. Also, if someone could make a forum with an emoji with it, it should not show up correctly. Let me know.

vagueGM

Aug 30, 2024 8:29 pm

Need testers for some big changes on staging

💡 Gamers' Plane development now shows all the emojis in the thread names.

A thread with emojis does not show them [ref].

Keleth says:

... Also, if someone could make a forum with an emoji with it, it should not show up correctly. Let me know.

When you say make a 'forum' do you mean a 'game'?

vagueGM

Aug 30, 2024 8:40 pm

Need testers for some big changes on staging

I create a game with an emoji in the title, it shows up correctly.

See the Game List and the Game Details page.

Let me know if that was not what you meant, or if that 'should not show up' was meant to be 'should now show up'. :)

vagueGM

Aug 30, 2024 8:49 pm

Need testers for some big changes on staging

The email about the new game calls it 'New Game: â Œ emoji game' in the subject line, messing up the emoji.

In the body of the email is displays the emoji correctly as 'game for 2 players called " emoji game".' ... which did not copy paste correct? Strange? The text is actually 'game for 2 players called "â\235\214 emoji game".' but gmail is sorta fixing it to display?

FlyingSucculent

Aug 30, 2024 9:15 pm

Need testers for some big changes on staging

Out of curiosity I also made a game with a fully Cyrillic name.

It displays correctly in:
- Game Details.
- Forum listings (https://staging.gamersplane.com/forums/).
- Game listings (https://staging.gamersplane.com/games/list).
- Games dropdown menu.
- My Games (https://staging.gamersplane.com/games/my).
- Game's ACP.
- Subscriptions.
- Main page.

It does not display correctly in:
- Heading on the game's forum itself (orange heading in https://staging.gamersplane.com/forums/11552). However, if you go into a thread inside the game, the very same heading looks fine.
- Subforum addresses in the game (it looks like Index > Game Forums > ????).
- Email about new subscription posts: it looks like "FlyingSucculent made a new post in the thread "" in the ???? forum." Both the game name and the thread name are the same, btw, so that's interesting.

Last edited August 30, 2024 9:19 pm

Keleth

Aug 30, 2024 11:15 pm

Need testers for some big changes on staging

Ok, that's what I needed. Someone on SO said that when you convert a table, it doesn't convert the data inside. I'm gonna have to write a script that will update every forum post with it's title converted, and we should be good. Same with post bodies and any other place emojis are.

Keleth

Aug 30, 2024 11:18 pm

Need testers for some big changes on staging

Ok, can someone check if games from prod with emojis in the title are showing up correctly? And to confirm, any new games you created with emojis in the title aren't?

FlyingSucculent

Aug 30, 2024 11:32 pm

Need testers for some big changes on staging

Erm, it seems that I can see all emojis on staging now? I made two new games titled "❤️❤️❤️" and "💡💡💡 Test" respectively, and they display correctly everywhere. Same with Cyrillics (except the old one).

Edit: except in emails, it seems, those are still broken.

Last edited August 30, 2024 11:37 pm

Keleth

Aug 30, 2024 11:38 pm

Need testers for some big changes on staging

New data should always have been working. It's old data that's problematic. Do old games forums now show emojis in the title?

FlyingSucculent

Aug 30, 2024 11:42 pm

Need testers for some big changes on staging

Well, the new data with Cyrillic didn't work before for whatever reason. Works now though, so idk.

I can see the emoji in GP Develpment game for what's it worth, but I can't check if it looks fine inside since it's private. And I'm not in any games with emojis, so unfortunately I can't check that further. :(

Edit: ooh, I forgot, I am in one retired game with an emoji in title. It looks fine.

Last edited August 30, 2024 11:48 pm

Keleth

Aug 30, 2024 11:55 pm

Need testers for some big changes on staging

Ok, then the solution is working. So, next steps:
- Lets recap what's still wrong with staging. I know there's some data missing, please let me know what that was
- Lets list out what data has/likely has emojis so I can fix all the fields

FlyingSucculent

Aug 31, 2024 12:05 am

Need testers for some big changes on staging

Keleth says:

- Lets recap what's still wrong with staging. I know there's some data missing, please let me know what that was

Bookmarks for games and characters get messed up on import.
Some private games are randomly marked public (but are not functionally public).
Subscription are empty (I can't actually confirm if it's still true since I don't have any, but vagueGM reported it earlier.)
Advanced rules definitions display without line breaks, with \n instead.

[ +- ] Example

"{\n\"characterSheetIntegration\":true,\n\"diceRules\":[\n{\"rolled\": \"2d6\",\"reason\":\"SR: 5-##\",\"total\": \"5<=x<=##\",\"highlight\": \"bold success\",\"contentAppend\": \"✅\"},\n{\"rolled\": \"d6\",\"lastDie\":\"true\",\"highlight\":\"info bold invert\",\"autoSort\":\"true\",\"hideTotal\":true},\n{\"rolled\": \"D20\", \"autoSort\":true},\n{\"rolled\": \"D20\", \"natural\":20,\"highlight\": \"fail invert bold \"},\n{\"rolled\": \"D20\",\"reason\": \"TN 1\", \"natural\": \"<=1\", \"highlight\": \"success invert\", \"countTotal\": \"<=1\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 2\", \"natural\": \"<=2\", \"highlight\": \"success invert\", \"countTotal\": \"<=2\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 3\", \"natural\": \"<=3\", \"highlight\": \"success invert\", \"countTotal\": \"<=3\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 4\", \"natural\": \"<=4\", \"highlight\": \"success invert\", \"countTotal\": \"<=4\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 5\", \"natural\": \"<=5\", \"highlight\": \"success invert\", \"countTotal\": \"<=5\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 6\", \"natural\": \"<=6\", \"highlight\": \"success invert\", \"countTotal\": \"<=6\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 7\", \"natural\": \"<=7\", \"highlight\": \"success invert\", \"countTotal\": \"<=7\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 8\", \"natural\": \"<=8\", \"highlight\": \"success invert\", \"countTotal\": \"<=8\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 9\", \"natural\": \"<=9\", \"highlight\": \"success invert\", \"countTotal\": \"<=9\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 10\", \"natural\": \"<=10\", \"highlight\": \"success invert\", \"countTotal\": \"<=10\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 11\", \"natural\": \"<=11\", \"highlight\": \"success invert\", \"countTotal\": \"<=11\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 12\", \"natural\": \"<=12\", \"highlight\": \"success invert\", \"countTotal\": \"<=12\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 13\", \"natural\": \"<=13\", \"highlight\": \"success invert\", \"countTotal\": \"<=13\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 14\", \"natural\": \"<=14\", \"highlight\": \"success invert\", \"countTotal\": \"<=14\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 15\", \"natural\": \"<=15\", \"highlight\": \"success invert\", \"countTotal\": \"<=15\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 16\", \"natural\": \"<=16\", \"highlight\": \"success invert\", \"countTotal\": \"<=16\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 17\", \"natural\": \"<=17\", \"highlight\": \"success invert\", \"countTotal\": \"<=17\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 18\", \"natural\": \"<=18\", \"highlight\": \"success invert\", \"countTotal\": \"<=18\"},\n{\"rolled\": \"D20\",\"reason\": \"TN 19\", \"natural\": \"<=19\", \"highlight\": \"success invert\", \"countTotal\": \"<=19\"},\n{\"rolled\": \"D20\", \"natural\": \"1\",\"highlight\": \"info invert bold\",\"content\":\"Add 1 extra success\"}\n]\n}"

FlyingSucculent

Aug 31, 2024 12:31 am

Need testers for some big changes on staging

Keleth says:

- Lets list out what data has/likely has emojis so I can fix all the fields

[ +- ] To the best of my imagination

Chalrytharendir

Aug 31, 2024 1:49 am

Need testers for some big changes on staging

That's a great list!

Also character sheets

Last edited August 31, 2024 1:49 am

Chalrytharendir

Aug 31, 2024 1:50 am

Need testers for some big changes on staging

Also, well done Keleth on solving the emoji problem! That was a tough one!

Keleth

Aug 31, 2024 1:53 am

Need testers for some big changes on staging

Chalrytharendir says:

Also, well done Keleth on solving the emoji problem! That was a tough one!

I have a solution, though I don't understand parts of it. For those curious, the sum is this:

Quote:

SELECT CONVERT(BINARY(CONVERT(title USING latin1)) USING utf8mb4) FROM forums;

Why latin1? Why does prod work, even though the script I created to just pull and display the prod data doesn't?

vagueGM

Aug 31, 2024 12:33 pm

Need testers for some big changes on staging

Keleth says:

...

Quote:

SELECT CONVERT(BINARY(CONVERT(title USING latin1)) USING utf8mb4) FROM forums;

Why latin1? ...

My assumption when I suggested latin1 for the export/import process was that most data was entered by people/systems assuming ASCII as a baseline, so dropping all three byte character codes to being three separate bytes (even if not legit ACSII) instead of some broken utf8 combination, and then having the system interpret those three bytes back as utf8 might work. (Some of them might be smaller than three bytes, I don't claim any knowledge of what mysql is doing, I'm just preemptively casting Protection From Pedants. :)

latin1 because 'lowest common denominator' and all?

Keleth says:

... Why does prod work, even though the script I created to just pull and display the prod data doesn't?

That part does worry me. My concern is that you are fixing something for php that will require you to fix it again when you move away from php. But, since you have worked out how to fix it, that should not be too onerous?

The mysql command itself was showing the previously imported ones correctly while php was breaking them.
Now the mysql command is showing those that previously worked [ref] as broken.

I created a simple php8.2-cli container and it also prints the unicode as php7 does, so it is not an 'old php' issue.

vagueGM

Aug 31, 2024 1:10 pm

Need testers for some big changes on staging

So python (mysql.connector) also renders the above query correctly, so we can probably ignore the fact that the official mysql command line client is doing something weird.

Keleth

Aug 31, 2024 10:05 pm

Need testers for some big changes on staging

FlyingSucculent says:

Bookmarks for games and characters get messed up on import.
Some private games are randomly marked public (but are not functionally public).

Can you provide examples of these so I can compare?

FlyingSucculent says:

Subscription are empty (I can't actually confirm if it's still true since I don't have any, but vagueGM reported it earlier.)
Advanced rules definitions display without line breaks, with \n instead.

These two are fixed and can be confirmed.

FlyingSucculent

Sep 1, 2024 5:47 am

Need testers for some big changes on staging

Keleth says:

Can you provide examples of these so I can compare?

Bookmarks
For games, I'm missing all of my bookmarks, there is not a single bookmark on staging at all. For a direct comparison, games 2100, 2211 and 4545 are bookmarked on production and aren't on staging.
(Edit: oops, copied wrong IDs, fixed.)

For characters, on production I have only two bookmarks of custom/13984 and custom/17142, while on staging I have the same two and additionally 13thage/16701.

Game status
The following games are all private on production and are marked as public on staging:
2100, 4545, 4092.
(There are way more - it's most of my games, actually.)

Additionally, game 4467 is public on production but is private on staging.
I think it might have just flipped all private and public ones to the opposite?

Keleth says:

These two are fixed and can be confirmed.

Can confirm that advanced rules are fixed.

Last edited September 1, 2024 6:02 am

vagueGM

Sep 1, 2024 8:51 am

Need testers for some big changes on staging

My Game and Character bookmarks are nonsensical. What is displayed in the Games and Characters menu above does not reflect which games are marked in the Game and Character lists.

The marked lists are the same on both prod and staging, so the data came over, but the menu above does not reflect this data.

As shown in the below screenshot: Liv Diver is shown in the menu, but not marked in the list, Margery is marked but not shown.

vagueGM

Sep 1, 2024 8:57 am

Need testers for some big changes on staging

The Latest Games block on the front page is empty. It should at least show the games listed in the Latest Public Games tests which were created yesterday? On prod is shows both Public and Private games, @FlyingSucculent could you make one of your Test games Private so we can see if it separates them that way? (My emoji test game is gone.)

vagueGM

Sep 1, 2024 9:00 am

Need testers for some big changes on staging

My Subscription list only contains the Forums, not the Threads I have Subscribed to.

The Threads list is empty, the Forums list looks correct.

FlyingSucculent

Sep 1, 2024 9:08 am

Need testers for some big changes on staging

Awkwardly enough, I can't do anything with these games since their Game Details pages no longer exist. Forums do, but not the game pages themselves (and they aren't in my games list either).

vagueGM

Sep 1, 2024 9:13 am

Need testers for some big changes on staging

Ah, which might be why I can't see mine. :)

Older Game Details pages still work. It appears only Games created on staging are having this issue?

FlyingSucculent

Sep 1, 2024 9:14 am

Need testers for some big changes on staging

I think it's a re-import thing, maybe? If Keleth imported stuff in parts while fixing the Unicode issue.
Regardless, a new game I just made doesn't show up in Latest Games, so it's definitely a bug!

FlyingSucculent

Sep 1, 2024 9:24 am

Need testers for some big changes on staging

I found a new problem. In ACP of a freshly created game on staging the groups are messed up. It has the usual default group, but also what looks to be default groups from other games (can't take a screenshot right now, but here is how it looks):

Quote:

The Halls of Arden Vul [ Edit ][ Delete ]
❌ emoji game [ Edit ][ Delete ]
This is a new public test game (01.09) (Main Group)

None of the imported games had this happen, only this new one. It's public, so might be connected.

PS: is it supposed to be like this? I never actually ran a public game.

Last edited September 1, 2024 9:26 am

vagueGM

Sep 1, 2024 9:33 am

Need testers for some big changes on staging

I am getting new game emails even though I turned them off on my vagueTest account.

vagueGM

Sep 1, 2024 9:36 am

Need testers for some big changes on staging

FlyingSucculent says:

... PS: is it supposed to be like this? I never actually ran a public game.

P.S. I almost missed this, since I had already read your post before the edit. :(

No, you are not supposed to be seeing my ❌ emoji game in your ACP list.

My ACP looks correct.

FlyingSucculent

Sep 1, 2024 9:40 am

Need testers for some big changes on staging

Hmm. Did you check ACP on a staging-created game too? This is odd. Maybe I can try to make some more new games and see if they get it too.

vagueGM

Sep 1, 2024 9:41 am

Need testers for some big changes on staging

I don't have access to any games created on staging, that emoji game was the only one and it appears to belong to you now. I will make one later and see.

FlyingSucculent

Sep 1, 2024 9:43 am

Need testers for some big changes on staging

Yeah, new games have messed up groups. I made two and here are their respective groups:

Quote:

Тест [ Edit ][ Delete ]
Тест [ Edit ][ Delete ]
Show me a working ACP (Main Group)

Quote:

Trophy Gold: Roots of Old Kalduhr [ Edit ][ Delete ]
❤️❤️❤️ [ Edit ][ Delete ]
Show me ACP 2 (Main Group)

I'm not even in Trophy Gold. XD

Edit: also, the emoji game isn't actually in my ACP, only its player group is. Idk what's up with it.
Edit 2: to clarify, a player group for my new game is named after your emoji game. I don't think I actually have any control over the game's settings, it's just a weird name thing.

Last edited September 1, 2024 9:48 am

FlyingSucculent

Sep 1, 2024 9:53 am

Need testers for some big changes on staging

Small update: I also can't rename any player groups in ACP. Looks like this part of ACP is just having difficulties in general.

vagueGM

Sep 1, 2024 9:56 am

Need testers for some big changes on staging

I can't rename groups on prod either, when I hit the green tick it just resets the name back.

I don't think these Groups ever worked at all though, but don't recall details.

FlyingSucculent

Sep 1, 2024 9:59 am

Need testers for some big changes on staging

They did at some point I think, I vaguely (hehe) remember using them, including renaming some. Must've broke somewhere down the line? The weird new groups are strange though, I've never seen this happen on production.

Keleth

Sep 5, 2024 5:46 pm

Need testers for some big changes on staging

FlyingSucculent says:

The following games are all private on production and are marked as public on staging:
2100, 4545, 4092.
(There are way more - it's most of my games, actually.)

Additionally, game 4467 is public on production but is private on staging.
I think it might have just flipped all private and public ones to the opposite?

So it actually seems that PROD data is wrong, and there's a bug in the prod code (which I'm going to look at right now. It seems that in prod, all four forums are marked public, but the forums are private, and somehow the display for public/private is inverted. I'm going to have to write a patch to bring the two back into parity, and then future imports onto staging/prod update will be good. I'm going to consider this closed once I do.

As for bookmarks, this is an interesting one. Adam's code has the favorites by characterID/gameID. I can leave this if people really like it, but honestly, I don't. In v2, we can do an active check for the max number of favorites, or have something different for favorites vs what shows up in the header. In the short term, we have some choices:
- Go alphabetic
- Go by date created (ascending or descending, knowing only 10 will show)
- Go by date favorited (ascending or descending, knowing only 10 will show)
- Stay with the id, knowing it will change in the future
This is one of those I think needs to be brought in line a bit. I'm open to how we do it.

FlyingSucculent

Sep 5, 2024 6:07 pm

Need testers for some big changes on staging

What about the missing bookmarks on import? Or the added ones? It's not just the wrong order, prod/staging bookmark lists are different.

And for ordering, I'd personally prefer to have an ability to choose the order. Fully customisable would be ideal, but first 10 sounds fine too! Then again, I don't really use bookmarks a lot, so I don't think my opinion should have a lot of weight in this. :'D

Keleth

Sep 5, 2024 6:45 pm

Need testers for some big changes on staging

FlyingSucculent says:

What about the missing bookmarks on import? Or the added ones? It's not just the wrong order, prod/staging bookmark lists are different.

I'll look again, but best I could see the issue was the ordering. Maybe there's a query issue I'm missing. I'll dive in further.

FlyingSucculent

Sep 5, 2024 7:01 pm

Need testers for some big changes on staging

For convenience, the sheet which is inconsistent for me is 13thage/16701. It's not favorited on prod, but became favorited in the dropdown on staging after the import. (I think it was favorited at prod at some point, but not during the period the import data is from.

It almost looks like it's using old data for the header dropdown.

Last edited September 5, 2024 7:03 pm

Keleth

Sep 5, 2024 7:53 pm

Need testers for some big changes on staging

FlyingSucculent says:

For convenience, the sheet which is inconsistent for me is 13thage/16701. It's not favorited on prod, but became favorited in the dropdown on staging after the import. (I think it was favorited at prod at some point, but not during the period the import data is from.

It almost looks like it's using old data for the header dropdown.

It was bad querying! It was actually just marking that someone else has favorited your character, and thus was returning it as a favorite. I've changed it to only look for characters you've favorited. Can you check if it makes more sense now?

vagueGM

Sep 5, 2024 7:58 pm

Need testers for some big changes on staging

Character Favorites look correct now.
Games Favorites are not correct, it is showing 10 items. I only have 5 games marked, and not all of them are included in the 10.

Keleth

Sep 5, 2024 8:15 pm

Need testers for some big changes on staging

vagueGM says:

The Latest Games block on the front page is empty.

I just learned you can't compare a number to null in MySQL! Fixed this problem.

FlyingSucculent

Sep 5, 2024 8:22 pm

Need testers for some big changes on staging

I did not expect it to be someone else favoriting the sheet. :O Looks fine now!

And for the games, on staging I don't have any favourite games showing up on the main page (but the actual /games page seems more or less correct). The dropdown also shows some of the games which aren't bookmarked, despite there being more bookmarked ones: for example, games/4433 and games/4416 are not bookmarked, but show up in the dropdown over bookmarked ones. I tried adding a low ID game to bookmarks too, and it did not show up in the dropdown.

Keleth

Sep 6, 2024 1:35 am

Need testers for some big changes on staging

I made a bunch of tweaks to thread notifications. Can someone see if it fixes it for them? If not, another deep dive on the way!

Also, for game favorites, can someone give me a discrepancy example? A game ID that's favorited and showing on prod, but favorited and not showing on staging? That made finding the character issue really easy.

FlyingSucculent

Sep 6, 2024 8:30 am

Need testers for some big changes on staging

Can't check notifications right now, but here are some games that are favourited but don't show up on the main page for me:
1601, 1950, 4467, 4566.

Also, for some reason staging is working really bad for me right now, times slower than prod. Wonder if it's just me. D:

Chalrytharendir

Sep 6, 2024 2:05 pm

Need testers for some big changes on staging

Keleth says:

As for bookmarks, this is an interesting one. Adam's code has the favorites by characterID/gameID.

I was just testing bookmarks on the main site (Prod) and as far as I can tell, characters are ordered purely alphabetically (ignoring whether it is your own character or not), while games are sorted by two categories (top are games you are in, bottom are games you are not in). Within these categories they are ordered alphabetically (ignoring emojis?):

Top to bottom the gameids are:
2916
8003
10689
6963
5963
11533
2103
11538
6952
8862

Top five are games I'm in, bottom five are games I'm not in.

Last edited September 6, 2024 2:07 pm

Chalrytharendir

Sep 6, 2024 2:22 pm

Need testers for some big changes on staging

If I bookmark an 11th game, 8862 (Tutorial Development Game) is kicked off the list which is neither the lowest gameid, nor the highest gameid. It is the bottom of the two category alphabetical list.

Adam

Sep 6, 2024 3:09 pm

Need testers for some big changes on staging

Chalrytharendir says:

I was just testing bookmarks on the main site (Prod) and as far as I can tell, characters are ordered purely alphabetically (ignoring whether it is your own character or not), while games are sorted by two categories (top are games you are in, bottom are games you are not in). Within these categories they are ordered alphabetically (ignoring emojis?):

Looking at the code, I think you're right about games.

Characters should just be label sorted (code).

Keleth

Sep 6, 2024 5:52 pm

Need testers for some big changes on staging

Yah, the grouping is something I'll adjust in v2 as well. Make it all alphabetic, with a marking to note if you're in the game or not.

Keleth

Sep 6, 2024 7:29 pm

Need testers for some big changes on staging

FlyingSucculent says:

Can't check notifications right now, but here are some games that are favourited but don't show up on the main page for me:
1601, 1950, 4467, 4566.

I can confirm that these would display if we didn't limit to 10. So basically it's again about picking how we display favorites (by date, name, etc).

So I think for characters, I'm going to go by ID. That's what it currently is and while I don't love it, its at least something.

For games, my proposal is in the header we show only games you're in, sorted by when they were created, descending (so most recently created first).

Thoughts?

FlyingSucculent

Sep 7, 2024 1:13 pm

Need testers for some big changes on staging

Keleth says:

I can confirm that these would display if we didn't limit to 10. So basically it's again about picking how we display favorites (by date, name, etc).

It's not the dropdown menu. I don't see them on the main page. Main page doesn't have the limit, does it? (If it does, then it's prod that's broken since I'm seeing 19 games on it. XD)
Also, I don't see any bookmarked games on the main page, at all. Even if it was about the limit, something should've been visible?

PS: staging still works incredibly badly for me even on my main connection.

Last edited September 7, 2024 1:16 pm

Keleth

Sep 7, 2024 2:33 pm

Need testers for some big changes on staging

FlyingSucculent says:

I don't see them on the main page. Main page doesn't have the limit, does it?

The home page? The "Your Games" section at the bottom?

FlyingSucculent says:

Also, I don't see any bookmarked games on the main page, at all. Even if it was about the limit, something should've been visible?

Bookmarked games show up on the home page? That's weird, but I can fix that.

FlyingSucculent says:

PS: staging still works incredibly badly for me even on my main connection.

I'm not having an issue. Can anyone else weigh in?

Adam

Sep 7, 2024 2:42 pm

Need testers for some big changes on staging

Keleth says:

FlyingSucculent says:

Can't check notifications right now, but here are some games that are favourited but don't show up on the main page for me:
1601, 1950, 4467, 4566.

I can confirm that these would display if we didn't limit to 10. So basically it's again about picking how we display favorites (by date, name, etc).

So I think for characters, I'm going to go by ID. That's what it currently is and while I don't love it, its at least something.

For games, my proposal is in the header we show only games you're in, sorted by when they were created, descending (so most recently created first).

Thoughts?

Currently (looking at the code):

Games:
If you have no games bookmarked, it's the first six non-retired games (by id) that you're a player in, then alpha ordered (ignoring emoji).
If you have games bookmarked, it's all of those (no limit), ordered by those you play in, then alpha (ignoring emoji).

Characters are similar (limit of 6 until favouriting), but it appears the alpha sorting doesn't strip emoji.

The idea is that once a user starts favouriting things then they control how big the header gets.

Keleth

Sep 7, 2024 3:30 pm

Need testers for some big changes on staging

Adam says:

If you have no games bookmarked, it's the first six non-retired games (by id) that you're a player in, then alpha ordered (ignoring emoji).
If you have games bookmarked, it's all of those (no limit), ordered by those you play in, then alpha (ignoring emoji).

Characters are similar (limit of 6 until favouriting), but it appears the alpha sorting doesn't strip emoji.

The idea is that once a user starts favouriting things then they control how big the header gets.

Yah, but it's rough on design. I have a solution in mind for v2, but I don't love it right now. I guess I could leave it. Problem is with just SQL, I'm not sure I can change the limit based on if there are bookmarks or not.

Adam

Sep 7, 2024 3:32 pm

Need testers for some big changes on staging

Sure. I'm just saying what it does now, not what it should do.

FlyingSucculent

Sep 7, 2024 3:46 pm

Need testers for some big changes on staging

Keleth says:

The home page? The "Your Games" section at the bottom?

Keleth says:

Bookmarked games show up on the home page? That's weird, but I can fix that.

Wait, what? The "Bookmarked Games" section. There is no way it is not an intended feature.

FlyingSucculent sent a note to Keleth

Are you implying that you're deleting it for v2? Why?

Last edited September 7, 2024 3:47 pm

Chalrytharendir

Sep 7, 2024 5:49 pm

Need testers for some big changes on staging

Note: If you remove the bookmarked games that people aren't in from the header there is no other way to access them other then digging through the games list, which sort of defeats the purpose of being able to bookmark them.

I think we should keep things the same for now and revisit for V2. Currently, it is mostly alphabetically organized, which seems to be what most people favor.

I guess you could make one adjustment to make it more consistent. You could change the sorting to be alphabetical if no bookmarks are used (instead of sorting by id if no bookmarks are used). That way the header is always sorted alphabetically regardless of whether users have bookmarked or not.

FlyingSucculent

Sep 7, 2024 5:57 pm

Need testers for some big changes on staging

@Chalrytharendir
Can you check if staging is working fine for you, please, if you have a second?

Chalrytharendir

Sep 7, 2024 6:02 pm

Need testers for some big changes on staging

Seems completely broken to me at the moment. The website hangs indefinitely, only showing the header.

FlyingSucculent

Sep 7, 2024 6:11 pm

Need testers for some big changes on staging

Thank you, so it's not just me. I was about to go digging in browser settings. :'D

Chalrytharendir

Sep 7, 2024 6:17 pm

Need testers for some big changes on staging

No problem, I'm glad I saved you from the hell scape of messing with your browser settings for no reason XD

Keleth

Sep 7, 2024 10:08 pm

Need testers for some big changes on staging

Ok, then I need to figure out how to do a query that will limit it to 6 if no bookmarks, and as many booksmarks if there are.

Keleth

Sep 8, 2024 1:03 am

Need testers for some big changes on staging

Chalrytharendir says:

Note: If you remove the bookmarked games that people aren't in from the header there is no other way to access them other then digging through the games list, which sort of defeats the purpose of being able to bookmark them.

I think this is where some confusion has been coming in. We have bookmarked games on the home page (I just put in that fix, can you check FlyingSucculent). That's staying, regardless. I was thinking of removing all the dropdowns in the header for v2.

Keleth

Sep 8, 2024 1:27 am

Need testers for some big changes on staging

Ok, here's what I've done with the header:

Characters - If you have no characters favorited, it shows your first 6 characters, alphabetically. If you have characters favorited, it shows all your favorited characters only, alphabetically.

Games - If you have no games favorited, it shows your first 6 games, sorted by if you're the gm or not, then alphabetically in that sub group. If you have games favorited, it shows all your favorited games, sorted by if you're the gm or not, then alphabetically in that sub group.

Thoughts?

Chalrytharendir

Sep 8, 2024 1:55 am

Need testers for some big changes on staging

Keleth says:

I think this is where some confusion has been coming in. We have bookmarked games on the home page (I just put in that fix, can you check FlyingSucculent). That's staying, regardless. I was thinking of removing all the dropdowns in the header for v2.

Oh yeah, I forgot about that spot. Just checked staging and the bookmarked games section on the front page is working for me.

Chalrytharendir

Sep 8, 2024 1:55 am

Need testers for some big changes on staging

Keleth says:

Ok, here's what I've done with the header:

Characters - If you have no characters favorited, it shows your first 6 characters, alphabetically. If you have characters favorited, it shows all your favorited characters only, alphabetically.

Games - If you have no games favorited, it shows your first 6 games, sorted by if you're the gm or not, then alphabetically in that sub group. If you have games favorited, it shows all your favorited games, sorted by if you're the gm or not, then alphabetically in that sub group.

Thoughts?

That seems reasonable to me

Chalrytharendir

Sep 8, 2024 4:39 am

Need testers for some big changes on staging

Keleth says:

I think this is where some confusion has been coming in. We have bookmarked games on the home page (I just put in that fix, can you check FlyingSucculent). That's staying, regardless. I was thinking of removing all the dropdowns in the header for v2.

Actually, on closer inspection, staging is missing a bookmarked game for me. It's a game I'm not in, but I had bookmarked on the main site before migration (HERE). New bookmarks on staging of games I'm not in are added to that section of the front page.

FlyingSucculent

Sep 8, 2024 11:03 am

Need testers for some big changes on staging

Keleth says:

I think this is where some confusion has been coming in. We have bookmarked games on the home page (I just put in that fix, can you check FlyingSucculent).

On one hand, it matches the data in the /games/my menu on staging.
On the other, both don't match prod. Some games I haven't had bookmarked in years showed up in both /games/my and Bookmarked Games on the main page (specifically 2434 and 3186).

Edit: also, the main page seems to have lost Latest Public Posts section?

Last edited September 8, 2024 11:07 am

Keleth

Sep 8, 2024 1:53 pm

Need testers for some big changes on staging

I'll look into all 3 games. I may not quite have the query down right. And I'll look into the Latest Public Posts section.

While I'm at those, since we've made a lot of progress, anyone know of any other bugs I still missed? I went back through the thread and think I caught everything. If nothing is standing out, what I can do after I fix the favorites issue at hand is do another data dump, do the updated steps, to make sure it works as expected, and then we can do a clean run through.

We're close, I think. Fixing some of these bugs seems to have sped staging back up?

Chalrytharendir

Sep 8, 2024 1:57 pm

Need testers for some big changes on staging

FlyingSucculent says:

Keleth says:

I think this is where some confusion has been coming in. We have bookmarked games on the home page (I just put in that fix, can you check FlyingSucculent).

On one hand, it matches the data in the /games/my menu on staging.
On the other, both don't match prod. Some games I haven't had bookmarked in years showed up in both /games/my and Bookmarked Games on the main page (specifically 2434 and 3186).

Edit: also, the main page seems to have lost Latest Public Posts section?

I think the database was over a week old, so there weren't any "latest" posts. I just made some post now, check again now.

Also, staging is working for me again and is working fast again.

FlyingSucculent

Sep 8, 2024 2:22 pm

Need testers for some big changes on staging

Chalrytharendir says:

I think the database was over a week old, so there weren't any "latest" posts. I just made some post now, check again now.

Hmm, it did appear. Although last time this was the case (before import?), there was still the heading and just no posts, which is what threw me off this time. :'D The main page looks very odd when these sections disappear, but I suppose it's not necessarily a bug.

FlyingSucculent

Sep 8, 2024 2:27 pm

Need testers for some big changes on staging

Keleth says:

While I'm at those, since we've made a lot of progress, anyone know of any other bugs I still missed?

Did you look into ACP group permissions (report post, follow-up)?
Also can't rename player groups in ACP on both prod and staging.

No one ever confirmed if notifications are checked, someone with active subscriptions should get on that. (I don't know how they should work, so not a good tester.)

Edit: mark as unread doesn't work for me.

Last edited September 8, 2024 2:30 pm

vagueGM

Sep 8, 2024 3:16 pm

Need testers for some big changes on staging

Keleth says:

... do another data dump, do the updated steps, to make sure it works as expected, and then we can do a clean run through.
...

I also have one game that is Favorited on prod but not marked as such on Staging. If these are the only things that are getting lost on the transfer it is not a bit deal, we can also always rebuild the 20 items in the favorite lists... but why is stuff getting lost? Let's see what the next data dump does.

User portraits did all transfer through, but we were told to ignore that issue.

Keleth says:

... I think. Fixing some of these bugs seems to have sped staging back up?

Speed seems good.

Keleth says:

... anyone know of any other bugs I still missed? ...

Emojis are still showing wrong, as seen in staging's version of this thread: [ref].

FlyingSucculent says:

... No one ever confirmed if notifications are checked, someone with active subscriptions should get on that. ...

They were working, but are not working now.
Emails would probably not get through since staging is trying to sign mails as gamersplane.com and does not have the key, but I am not seeing logs about any attempts to send at all.

Keleth

Sep 8, 2024 3:18 pm

Need testers for some big changes on staging

Chalrytharendir says:

Actually, on closer inspection, staging is missing a bookmarked game for me. It's a game I'm not in, but I had bookmarked on the main site before migration (HERE). New bookmarks on staging of games I'm not in are added to that section of the front page.

I was not returning retired games, but it makes sense to leave retired games returning for favorites.

FlyingSucculent says:

2434 and 3186

Did you mean 3086? 3186 doesn't show up on staging or prod. And if you did mean those two, they were both in the data dump I took for the transfer. They're not in prod now, and doing a data dump at this time shows they're not in those values. I'm guessing you had them favorited at the time.

vagueGM

Sep 8, 2024 3:22 pm

Need testers for some big changes on staging

The game that is missing from my favorites on staging is the 💡 Gamers' Plane development which I added to my favorites on prod when we started the issue with the emojis, so it might not have been favorited at the time the data was dumped?

Keleth

Sep 8, 2024 3:25 pm

Need testers for some big changes on staging

vagueGM says:

I also have one game that is Favorited on prod but not marked as such on Staging. If these are the only things that are getting lost on the transfer it is not a bit deal, we can also always rebuild the 20 items in the favorite lists... but why is stuff getting lost? Let's see what the next data dump does.

So far, it hasn't appeared to be missing, rather the queries I'm writing don't quite do what we want. It's been incremental improvement. As noted just above, I was filtering out retired games. Was the game you favorited that wasn't showing up retired? Can you give me the id?

vagueGM says:

User portraits did all transfer through, but we were told to ignore that issue.

I haven't copied any images over, so portraits won't show. Some images are hardlinked to gamersplane.com, while others are relatively linked, so it depends.

vagueGM says:

Emojis are still showing wrong, as seen in staging's version of this thread: [ref].

vagueGM says:

They were working, but are not working now.

Can you clarify? They're not showing up now on the home page top?

vagueGM says:

Emails would probably not get through since staging is trying to sign mails as gamersplane.com and does not have the key, but I am not seeing logs about any attempts to send at all.

I shut down the postfix server to avoid emails going through while I figure out why it was sending emails it shouldn't be. But yah, I never set up a staging key, a problem for later.

vagueGM

Sep 8, 2024 3:44 pm

Need testers for some big changes on staging

Keleth says:

... Was the game you favorited that wasn't showing up retired? ...

Not retired. When I add to the list on staging it shows.

Keleth says:

... Can you give me the id? ...

3181

Keleth says:

... I haven't copied any images over, so portraits won't show. ...

No worries then. :)

Keleth says:

...

vagueGM says:

They were working, but are not working now.

Can you clarify? They're not showing up now on the home page top? ...

This was about notification emails. Sorry for the confusion, words are hard. :)

Keleth says:

... I shut down the postfix server ...

Good idea. I started it again for this test, and no mails showed up in logs.

I shut it down again in case there were problems.

Keleth says:

... I never set up a staging key ...

There is a staging key, and opendkim appears to be configured to use it. The logs from 8 days ago show it was trying to use prod's domain and keys at that time, but it should use be using the correct ones now.

FlyingSucculent

Sep 8, 2024 3:50 pm

Need testers for some big changes on staging

Keleth says:

FlyingSucculent says:

2434 and 3186

Did you mean 3086? 3186 doesn't show up on staging or prod. And if you did mean those two, they were both in the data dump I took for the transfer. They're not in prod now, and doing a data dump at this time shows they're not in those values. I'm guessing you had them favorited at the time.

Oops, accidentally copied the forum ID instead of the game's, it was 1335.
But 2434 is very strange. Is this dump a few years old? This game ended a few years ago, and I moved it from the bookmarks soon after. I'm pretty sure I never added it again.
(And 1335 definitely shouldn't be in recent dumps, it is 4 years old.)

Well, it's probably not a big problem anyway, it'd be worse if games disappeared instead of appearing!

Last edited September 8, 2024 3:58 pm

Keleth

Sep 8, 2024 4:24 pm

Need testers for some big changes on staging

So I messed up something BAD on staging and am doing a full data load of prod as of 5 minutes ago. It'll be unavailable while I do so. This'll be a good test of the current state of things.

Keleth

Sep 8, 2024 6:21 pm

Need testers for some big changes on staging

Ok, staging is back up with the latest data. Please tell me if things look good, specially for the concerns over recent posts/sections that were missing possibly due to stale data. Emoji's don't work right now (that's what I broke earlier). I'm working on it. Anything else should be good.

Chalrytharendir

Sep 8, 2024 9:23 pm

Need testers for some big changes on staging

It's working fast, front page looks right to me.

When I checked a game I found a few problems: Players' avatars are not all correct (e.g. mine, Harrigan, Windyridge all look correct, KCC is wrong, Len is missing), character avatars are missing, and the character menu in the footer isn't working again (shows only my character).

For comparison see player avatar, character avatar, menu:

(Note: This is a private game, so Keleth might be the only one who can check, but I've added screenshots too)

Staging

Prod

Last edited September 9, 2024 2:11 am

vagueGM

Sep 8, 2024 9:28 pm

Need testers for some big changes on staging

Clicking the Games menu at the top is taking me straight to the /games/ page and not showing the menu. The Characters menu is working as intended.

FlyingSucculent

Sep 8, 2024 9:29 pm

Need testers for some big changes on staging

@Chalrytharendir, avatars missing is a temporary thing.

Keleth says:

vagueGM says:

• A few random players in my games are missing portraits. This might be an irrelevant symptom of how the data was transferred, but met us know if you want us to report each occurrence of such. The data seems to be out of date, so I don't know if those players did not have portraits at that time.

• Character posts are showing the player's portrait.

Yah, don't worry about the avatars.

The Games dropdown stopped showing up for me, otherwise things look fine at a first glance. And the ACP thing is fixed, yay.

Last edited September 8, 2024 9:30 pm

Keleth

Sep 9, 2024 12:25 am

Need testers for some big changes on staging

Character footer and games dropdown in header. I'll work on those.

Chalrytharendir

Sep 9, 2024 2:14 am

Need testers for some big changes on staging

FlyingSucculent says:

@Chalrytharendir, avatars missing is a temporary thing.

Ooops, didn't realize. It's hard keeping track of what's been reported already 😅

FlyingSucculent

Sep 9, 2024 12:01 pm

Need testers for some big changes on staging

Maybe it can be useful to have some sort of master post to record everything in? A Google doc, maybe? I can keep track of it! Although since most of the things are fixed, maybe there is no real need now. XD

Chalrytharendir

Sep 9, 2024 1:28 pm

Need testers for some big changes on staging

That's a great idea. I guess let's see where we're at next time Keleth checks in, but if there's still a lot of testing to do, a master list of known bugs would be great. Also a check list of features that still need testing/retesting would be useful too.

Keleth

Sep 9, 2024 9:23 pm

Need testers for some big changes on staging

I made a doc as suggested: https://docs.google.com/document/d/1gWMtX6EuPcBJ5Vvvwh1zXfZiy4FzCSjTcdQPh0Cmz_g/edit?usp=sharing. Also, as I can't find it, we need to relist any fields we think/know have emoji's in it so I can update them.

FlyingSucculent

Sep 9, 2024 10:08 pm

Need testers for some big changes on staging

List. :3

FlyingSucculent says:

Keleth says:

- Lets list out what data has/likely has emojis so I can fix all the fields

[ +- ] To the best of my imagination

Chalrytharendir also mentioned character sheets, but I didn't add them since they're a different system, right?

Last edited September 9, 2024 10:09 pm

Chalrytharendir

Sep 10, 2024 2:37 pm

Need testers for some big changes on staging

Keleth says:

I made a doc as suggested: https://docs.google.com/document/d/1gWMtX6EuPcBJ5Vvvwh1zXfZiy4FzCSjTcdQPh0Cmz_g/edit?usp=sharing. Also, as I can't find it, we need to relist any fields we think/know have emoji's in it so I can update them.

Awesome, thanks!

Found another one to add this morning:

If a character is in a game, then when you are viewing the character sheet page, there are usually links to the game forum and game details pages in the footer. On staging those are missing at the moment.

But feels like bugs are getting harder to find, so I think we're getting close!

Mark as unread

Preview

Post Preview

You do not have permission to post in this thread.